Git development
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: me@black-desk.cn
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] b4: include change-id in cover template
Date: Fri, 10 Jul 2026 10:46:58 +0200	[thread overview]
Message-ID: <alCxgqybWb9eDEG0@pks.im> (raw)
In-Reply-To: <20260710-add-change-id-to-b4-template-v1-1-1bd37a25064e@black-desk.cn>

On Fri, Jul 10, 2026 at 03:22:13PM +0800, Chen Linxuan via B4 Relay wrote:
> From: Chen Linxuan <me@black-desk.cn>
> 
> With b4 0.15.2, I hit a local failure after sending a series with the
> in-tree cover template.  The generated sent/<change-id>-vN tag contained
> base-commit, but did not contain change-id, and later b4 commands failed
> when trying to read it:
> 
>   CRITICAL: Tag sent/... does not contain change-id info
> 
> Looking at b4's source, the sent tag message is derived from the rendered
> cover letter.  The same code later parses that tag and expects both
> base-commit and change-id to be present.  The default b4 cover template
> has both trailers, but our in-tree template only has base-commit.
> 
> Add the missing change-id trailer next to base-commit so sent tags
> produced from the project template remain readable by b4's reroll and
> comparison logic.

Ah, that's indeed an oversight on my side. So this change looks good to
me, thanks!

Patrick

  reply	other threads:[~2026-07-10  8:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10  7:22 [PATCH] b4: include change-id in cover template Chen Linxuan via B4 Relay
2026-07-10  8:46 ` Patrick Steinhardt [this message]
2026-07-10 17:02   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alCxgqybWb9eDEG0@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@black-desk.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox