From: Patrick Steinhardt <ps@pks.im>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Elijah Newren <newren@gmail.com>, Jeff King <peff@peff.net>,
"brian m . carlson" <sandals@crustytoothpaste.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Justin Tobler <jltobler@gmail.com>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH] fast-export: standardize usage string and SYNOPSIS
Date: Tue, 14 Jul 2026 10:54:14 +0200 [thread overview]
Message-ID: <alX5Nl8uX4ctVqo3@pks.im> (raw)
In-Reply-To: <20260713124153.245268-1-christian.couder@gmail.com>
On Mon, Jul 13, 2026 at 02:41:53PM +0200, Christian Couder wrote:
> diff --git a/Documentation/git-fast-export.adoc b/Documentation/git-fast-export.adoc
> index 297b57bb2e..719aeca244 100644
> --- a/Documentation/git-fast-export.adoc
> +++ b/Documentation/git-fast-export.adoc
> @@ -9,7 +9,7 @@ git-fast-export - Git data exporter
> SYNOPSIS
> --------
> [verse]
> -'git fast-export' [<options>] | 'git fast-import'
> +'git fast-export' [<options>] [<revision-range>] [[--] <path>...]
>
> DESCRIPTION
> -----------
Makes sense, as it is more consistent with all the other commands that
we have. I don't recall any other commands that use "|".
> diff --git a/builtin/fast-export.c b/builtin/fast-export.c
> index 0be43104dc..629d7c591a 100644
> --- a/builtin/fast-export.c
> +++ b/builtin/fast-export.c
> @@ -33,7 +33,7 @@
> #include "gpg-interface.h"
>
> static const char *const fast_export_usage[] = {
> - N_("git fast-export [<rev-list-opts>]"),
> + N_("git fast-export [<options>] [<revision-range>] [[--] <path>...]"),
> NULL
> };
>
This is being adapted to match.
> diff --git a/t/t0450/adoc-help-mismatches b/t/t0450/adoc-help-mismatches
> index e8d6c13ccd..c4a55ff4e3 100644
> --- a/t/t0450/adoc-help-mismatches
> +++ b/t/t0450/adoc-help-mismatches
> @@ -12,7 +12,6 @@ column
> credential
> credential-cache
> credential-store
> -fast-export
> fast-import
> fetch-pack
> fmt-merge-msg
And as both match now we can also update t0450. Nice!
Patrick
prev parent reply other threads:[~2026-07-14 8:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 12:41 [PATCH] fast-export: standardize usage string and SYNOPSIS Christian Couder
2026-07-13 15:54 ` Junio C Hamano
2026-07-14 8:54 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alX5Nl8uX4ctVqo3@pks.im \
--to=ps@pks.im \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jltobler@gmail.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox