Git development
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: sgala@hisitech.com
Cc: git@vger.kernel.org, Santiago Gala <sgala@apache.org>
Subject: Re: [PATCH] make --color-words separate word on ispunct
Date: Sat, 12 Apr 2008 16:23:32 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.1.00.0804121621560.16366@eeepc-johanness> (raw)
In-Reply-To: <1207996421-29651-1-git-send-email-sgala@apache.org>

Hi,

On Sat, 12 Apr 2008, sgala@hisitech.com wrote:

> Note that this may actually be harmful when trying to spot punctuation 
> changes, but for this use case I don't think color-words is helping now 
> either.

I do not know how commonly supported ispunct(), therefore I do not like 
the patch too much.

Besides, since long ago I want to make the list of boundary characters 
configurable, preferably as a tr(1) style list, but I have not come around 
to do that yet.

Ciao,
Dscho

  reply	other threads:[~2008-04-12 15:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-12 10:33 [PATCH] make --color-words separate word on ispunct sgala
2008-04-12 15:23 ` Johannes Schindelin [this message]
2008-04-12 15:32   ` Ping Yin
2008-04-12 17:50     ` Santiago Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.0804121621560.16366@eeepc-johanness \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=sgala@apache.org \
    --cc=sgala@hisitech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox