From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: [PATCH 1/3] Add --blob-filter option to filter-branch. Date: Wed, 23 Apr 2008 21:14:16 +0100 (BST) Message-ID: References: <1208979757-30860-1-git-send-email-apenwarr@gmail.com> <32541b130804231312n50e86ce6g2b2331ca514ba982@mail.gmail.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: git@vger.kernel.org, Jeff King To: Avery Pennarun X-From: git-owner@vger.kernel.org Wed Apr 23 22:15:07 2008 connect(): Connection refused Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JolMu-0001SI-4a for gcvg-git-2@gmane.org; Wed, 23 Apr 2008 22:15:04 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754017AbYDWUOS (ORCPT ); Wed, 23 Apr 2008 16:14:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754097AbYDWUOS (ORCPT ); Wed, 23 Apr 2008 16:14:18 -0400 Received: from mail.gmx.net ([213.165.64.20]:48435 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753774AbYDWUOR (ORCPT ); Wed, 23 Apr 2008 16:14:17 -0400 Received: (qmail invoked by alias); 23 Apr 2008 20:14:15 -0000 Received: from cbg-off-client.mpi-cbg.de (EHLO eeepc-johanness.mpi-cbg.de) [141.5.11.5] by mail.gmx.net (mp057) with SMTP; 23 Apr 2008 22:14:15 +0200 X-Authenticated: #1490710 X-Provags-ID: V01U2FsdGVkX1/Ua8Yuou7UD+yIKX0DzNPDEumwORvc3qFNE2Fgh2 2mnzn4RvZ9p3bI X-X-Sender: user@eeepc-johanness In-Reply-To: <32541b130804231312n50e86ce6g2b2331ca514ba982@mail.gmail.com> User-Agent: Alpine 1.00 (DEB 882 2007-12-20) X-Y-GMX-Trusted: 0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Hi, On Wed, 23 Apr 2008, Avery Pennarun wrote: > On 4/23/08, Johannes Schindelin wrote: > > Not all of this belongs in the commit messaage. > > > > > Acked-by: Johannes Schindelin > > > > This does. > > > > A good general rule is: if you think it would be funny/strange to > > read this message in the output of "git log", it should be changed. > > I felt uncomfortable modifying the message attached to Jeff's patch > (which actually does pretty clearly explain what's going on), since > it's not mine. If he wants to send me a better commit message, > that'll be fine too. Well, I think that you would do a good job rephrasing this as a proper commit message :-) Ciao, Dscho