Git development
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Brian Gernhardt <benji@silverinsanity.com>
Cc: "Jörg Sommer" <joerg@alea.gnuu.de>, git@vger.kernel.org
Subject: Re: [PATCH] Use perl instead of tac
Date: Mon, 28 Apr 2008 15:20:58 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.1.00.0804281520220.5399@eeepc-johanness> (raw)
In-Reply-To: <E58664C1-86E5-452A-A7CD-2007DD59A75E@silverinsanity.com>

Hi,

On Mon, 28 Apr 2008, Brian Gernhardt wrote:

> On Apr 28, 2008, at 9:46 AM, Johannes Schindelin wrote:
> 
> >How about fixing the code to not need tac instead?  We went to great 
> >lengths to introduce the --reverse option to the rev-list command, in 
> >order to avoid tac in the original version of rebase -i.
> 
> Because this is reversing the output of a sub-shell (ll.395-471), not 
> rev-list.  And making the shell code insert commands before the lines 
> the produce it would make the code complex at best.  (And it's not 
> simple code either.)

That's my _point_: the code is way too complex for what it tries to 
accomplish, namely implement a sane syntax for rebase -i -p.

Ciao,
Dscho

  reply	other threads:[~2008-04-28 14:21 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-27  6:24 Use of tac in git-rebase--interactive Brian Gernhardt
2008-04-27  6:42 ` Jeff King
2008-04-27  6:55   ` [PATCH] Use perl instead of tac Brian Gernhardt
2008-04-28  7:44     ` [PATCH] rebase--interactive: Replace unportable 'tac' by a sed script Johannes Sixt
2008-04-28  8:19       ` Junio C Hamano
2008-04-28  8:58         ` Paolo Bonzini
2008-04-28  9:04       ` Jeff King
2008-04-28  9:11         ` Andreas Ericsson
2008-04-28 11:46     ` [PATCH] Use perl instead of tac Jörg Sommer
2008-04-28 12:58       ` Randal L. Schwartz
2008-04-28 13:12         ` David Symonds
2008-04-28 13:31           ` Paolo Bonzini
2008-04-28 14:11           ` Brian Gernhardt
2008-04-28 14:22             ` Johannes Schindelin
2008-04-28 15:15         ` Jörg Sommer
2008-04-28 17:26           ` Avery Pennarun
2008-04-28 17:34           ` Matthieu Moy
2008-04-28 17:50             ` Brian Gernhardt
2008-04-28 19:13           ` Brian Gernhardt
2008-04-30  9:02             ` Jörg Sommer
2008-04-30  9:39               ` Jörg Sommer
2008-04-30 16:12                 ` Brian Gernhardt
2008-04-30 15:25               ` Brian Gernhardt
2008-05-04 22:13                 ` Jörg Sommer
2008-05-06  4:32                   ` Brian Gernhardt
2008-04-28 13:46       ` Johannes Schindelin
2008-04-28 14:07         ` Brian Gernhardt
2008-04-28 14:20           ` Johannes Schindelin [this message]
2008-04-27  7:33 ` Use of tac in git-rebase--interactive しらいしななこ
2008-04-30  0:25   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.0804281520220.5399@eeepc-johanness \
    --to=johannes.schindelin@gmx.de \
    --cc=benji@silverinsanity.com \
    --cc=git@vger.kernel.org \
    --cc=joerg@alea.gnuu.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox