From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: [PATCH v2 4/5] Make boundary characters for --color-words configurable Date: Wed, 7 May 2008 12:24:19 +0100 (BST) Message-ID: References: <46dff0320805020726y2592732cj9aef0111e5b2288a@mail.gmail.com> <46dff0320805031732x25286707r991358162046c07c@mail.gmail.com> <46dff0320805040935n22354e1bta85b3f3fe7c16cad@mail.gmail.com> <7v63ttq0y8.fsf@gitster.siamese.dyndns.org> <46dff0320805041840g1b9362d3u138b9d40cde160f2@mail.gmail.com> <7vprs1ny5e.fsf@gitster.siamese.dyndns.org> <46dff0320805050510t3bc5fd0eq44e0d58d1bb57629@mail.gmail.com> <46dff0320805051740o65eee07eqc7073e4fa7996277@mail.gmail.com> <46dff0320805061815k6aca9020g285b09da2bcf29c3@mail.gmail.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Junio C Hamano , git@vger.kernel.org To: Ping Yin X-From: git-owner@vger.kernel.org Wed May 07 13:25:20 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jthlp-000784-AL for gcvg-git-2@gmane.org; Wed, 07 May 2008 13:25:13 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752146AbYEGLYZ (ORCPT ); Wed, 7 May 2008 07:24:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752456AbYEGLYY (ORCPT ); Wed, 7 May 2008 07:24:24 -0400 Received: from mail.gmx.net ([213.165.64.20]:43443 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750932AbYEGLYX (ORCPT ); Wed, 7 May 2008 07:24:23 -0400 Received: (qmail invoked by alias); 07 May 2008 11:24:21 -0000 Received: from wbgn128.biozentrum.uni-wuerzburg.de (EHLO racer.local) [132.187.25.128] by mail.gmx.net (mp027) with SMTP; 07 May 2008 13:24:21 +0200 X-Authenticated: #1490710 X-Provags-ID: V01U2FsdGVkX1/XB1wbSCDXyy0K151NL4qadE3mK/t6j5ZnUKp8OE LsA2IFzbwyD2qR X-X-Sender: gene099@racer In-Reply-To: <46dff0320805061815k6aca9020g285b09da2bcf29c3@mail.gmail.com> User-Agent: Alpine 1.00 (DEB 882 2007-12-20) X-Y-GMX-Trusted: 0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Hi, On Wed, 7 May 2008, Ping Yin wrote: > On Tue, May 6, 2008 at 4:55 PM, Johannes Schindelin > wrote: > > > I will come up with an implementation still using diff.nonwordchars few > > > days later. > > > > If I did not like the unnecessary negative approach "nonwordchars" (as > > opposed to "wordchars"), it seems even less appropriate now, when you > > actually want to discern between "spaceCharacters", > > "punctuationCharacters" and "wordCharacters". > > > > Hmm, punctchars should be a better word than nonwordchars. > > So how about this > > --color-words={char,punct,word} > > - char: one char one token > - punct/word: a token can be either a run of word characters or a > single punct character. diff.punctchars is used for punct, and > diff.wordchars is used for word. I am rather interested in the semantics, i.e. if you can punch holes into this 3-class approach. Bikeshedding comes later ;-) Ciao, Dscho