From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Provide git_config with a callback-data parameter
Date: Thu, 15 May 2008 02:02:45 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.1.00.0805150156230.30431@racer> (raw)
In-Reply-To: <7vk5hwn0tp.fsf@gitster.siamese.dyndns.org>
Hi,
On Wed, 14 May 2008, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > git_config() only had a function parameter, but no callback data
> > parameter. This assumes that all callback functions only modify
> > global variables.
> >
> > With this patch, every callback gets a void * parameter, and it is hoped
> > that this will help the libification effort.
>
> Great, as this has also been a pet-peeve of mine for quite some time.
>
> Except the patch has quite a many rejects X-<.
Did you try to apply it to "next"? I thought I based it on "next"... I
will prepare three patches tomorrow: for "next", "master" and "maint"
respectively (even if I think that "maint" should not take it; it is no
real fix).
Ciao,
Dscho
next prev parent reply other threads:[~2008-05-15 1:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 17:46 [PATCH 0/2] Fix two pet peeves of mine Johannes Schindelin
2008-05-14 17:46 ` [PATCH 1/2] Rename path_list to string_list Johannes Schindelin
2008-05-14 17:46 ` [PATCH 2/2] Provide git_config with a callback-data parameter Johannes Schindelin
2008-05-14 19:27 ` Junio C Hamano
2008-05-15 1:02 ` Johannes Schindelin [this message]
2008-05-15 1:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0805150156230.30431@racer \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox