From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Robin Rosenberg <robin.rosenberg@dewire.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] cvsexportcommit: chomp only removes trailing whitespace
Date: Thu, 15 May 2008 04:21:09 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.1.00.0805150421000.30431@racer> (raw)
In-Reply-To: <7vk5hwi9o4.fsf@gitster.siamese.dyndns.org>
Hi,
On Wed, 14 May 2008, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > @@ -210,7 +210,7 @@ if (@canstatusfiles) {
> > my $basename = basename($name);
> >
> > $basename = "no file " . $basename if (exists($added{$basename}));
> > - chomp($basename);
> > + $basename =~ s/^\s+(.*?)\s*$/$1/;
>
> Isn't this no-op for a basename that does not begin with a whitespace?
> Don't you want to still strip trailing whitespaces in such a case?
D'oh. Time for bed.
Ciao,
Dscho
prev parent reply other threads:[~2008-05-15 3:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 14:27 [PATCH 1/2] cvsexportcommit: chomp only removes trailing whitespace Johannes Schindelin
2008-05-14 14:29 ` [PATCH 2/2] cvsexportcommit: introduce -W for shared working trees (between Git and CVS) Johannes Schindelin
2008-05-14 17:58 ` [PATCH 1/2] cvsexportcommit: chomp only removes trailing whitespace Junio C Hamano
2008-05-14 18:38 ` Johannes Schindelin
2008-05-14 20:06 ` Robin Rosenberg
2008-05-14 22:15 ` Johannes Schindelin
2008-05-14 22:30 ` [PATCH 1/2 v2] " Johannes Schindelin
2008-05-15 2:27 ` Junio C Hamano
2008-05-15 3:21 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0805150421000.30431@racer \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox