Git development
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: David Reiss <dreiss@facebook.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] Implement normalize_absolute_path
Date: Tue, 20 May 2008 13:22:41 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.1.00.0805201321300.30431@racer> (raw)
In-Reply-To: <48327456.1060202@facebook.com>

Hi,

On Mon, 19 May 2008, David Reiss wrote:

> normalize_absolute_path removes several oddities form absolute paths, 
> giving nice clean paths like "/dir/sub1/sub2".  Also add a test case for 
> this utility, based on a new test program (in the style of test-sha1).

I wonder why my advice to look at setup.c (I think I did not mention the 
function name "sanitary_path_copy()" in particular, because I figured you 
would spot it right away) went unheeded.

So I think I will not even bother to look at your patches either.

Ciao,
Dscho

  reply	other threads:[~2008-05-20 12:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20  6:48 [PATCH 1/4] Implement normalize_absolute_path David Reiss
2008-05-20 12:22 ` Johannes Schindelin [this message]
2008-05-20 16:44   ` David Reiss
2008-05-20 22:24 ` Alex Riesen
2008-05-21  8:34   ` David Reiss
2008-05-22 12:48     ` Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.0805201321300.30431@racer \
    --to=johannes.schindelin@gmx.de \
    --cc=dreiss@facebook.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox