Git development
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Clemens Buchacher <drizzd@aon.at>
Cc: Junio C Hamano <junio@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] lockfile: reset the correct signal
Date: Mon, 26 May 2008 22:36:45 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.1.00.0805262234210.30431@racer> (raw)
In-Reply-To: <20080526193513.GA9978@localhost>

Hi,

On Mon, 26 May 2008, Clemens Buchacher wrote:

> In the function remove_lock_file_on_signal(), the signal handler
> for SIGINT was reset, ignoring the parameter signo.
> 
> This did not pose a problem yet, as remove_lock_file_on_signal()
> was only registered as a SIGINT handler.
> 
> Signed-off-by: Clemens Buchacher <drizzd@aon.at>
> ---
> 
> On Mon, May 26, 2008 at 10:34:11AM +0100, Johannes Schindelin wrote:
> > Only from the patch did I understand that you actually meant:
> 
> Thank you for fixing that.

Unfortunately, the original patch is already in git.git.

> I also realized that using signals like that can cause races. Shouldn't 
> we use sigaction() instead of signal()?

Dunno.  The man page suggests it, but we have plenty of cases where we use 
signal().  And I think it might be less painful to implement a 
compat-wrapper for the platforms which differ from Linux' interpretation 
of signal().

Ciao,
Dscho

  reply	other threads:[~2008-05-26 21:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-22 19:55 [PATCH] http-push: remove remote locks on exit signals Clemens Buchacher
2008-05-23 21:40 ` Junio C Hamano
2008-05-23 22:17   ` Clemens Buchacher
2008-05-25 18:26     ` [PATCH] Reset the signal being handled Clemens Buchacher
2008-05-26  9:34       ` Johannes Schindelin
2008-05-26 19:35         ` [PATCH] lockfile: reset the correct signal Clemens Buchacher
2008-05-26 21:36           ` Johannes Schindelin [this message]
2008-05-27  7:49             ` Clemens Buchacher
2008-05-25 18:27     ` [PATCH] http-push: remove remote locks on exit signals Clemens Buchacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.0805262234210.30431@racer \
    --to=johannes.schindelin@gmx.de \
    --cc=drizzd@aon.at \
    --cc=git@vger.kernel.org \
    --cc=junio@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox