Git development
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Pieter de Bie <pdebie@ai.rug.nl>
Cc: Git Mailinglist <git@vger.kernel.org>
Subject: Re: [PATCH] builtin-fast-export: Add importing and exporting of revision marks
Date: Thu, 5 Jun 2008 14:31:18 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.1.00.0806051429300.21190@racer> (raw)
In-Reply-To: <BEF1F17D-6F0F-4F09-9CC4-B193B8907901@ai.rug.nl>

Hi,

On Thu, 5 Jun 2008, Pieter de Bie wrote:

> On 5 jun 2008, at 02:00, Johannes Schindelin wrote:
> 
> >Is "- (uint32_t *)NULL" needed?
> 
> I changed the uintmax_t to to a uint32_t. If I remove the "- (uint32_t
> *)NULL", it won't return the same marks. The same is done in 
>  get_object_mark().

Ah, I missed that again.  I think I had exactly the same issue (of not 
understanding) with another patch for the same area of the code.

Maybe it would be worth having two functions to describe what is done 
there, for documentation purposes?

> I will send an updated patch.

Thanks,
Dscho

      parent reply	other threads:[~2008-06-05 13:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04 20:55 [PATCH] builtin-fast-export: Add importing and exporting of revision marks Pieter de Bie
2008-06-05  0:00 ` Johannes Schindelin
2008-06-05 10:46   ` Pieter de Bie
2008-06-05 10:52     ` [PATCH v2] " Pieter de Bie
2008-06-05 13:35       ` Johannes Schindelin
2008-06-06 23:09       ` Junio C Hamano
2008-06-07 13:06         ` Pieter de Bie
2008-06-07 15:19           ` Johannes Schindelin
2008-06-07 16:37             ` Junio C Hamano
2008-06-11 19:45               ` Johannes Schindelin
2008-06-07 13:25       ` [PATCH] Documentation/fast-export: Document --import-marks and --export-marks options Pieter de Bie
2008-06-07 15:20         ` Johannes Schindelin
2008-06-10  6:47         ` Junio C Hamano
2008-06-11 11:17           ` [PATCH v3] builtin-fast-export: Add importing and exporting of revision marks Pieter de Bie
2008-06-11 11:24             ` Pieter de Bie
2008-06-11 18:45             ` Johannes Schindelin
2008-06-11 21:43             ` Junio C Hamano
2008-06-05 13:31     ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.0806051429300.21190@racer \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=pdebie@ai.rug.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox