From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Pieter de Bie <pdebie@ai.rug.nl>
Cc: Git Mailinglist <git@vger.kernel.org>
Subject: Re: [PATCH v2] builtin-fast-export: Add importing and exporting of revision marks
Date: Thu, 5 Jun 2008 14:35:11 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.1.00.0806051433590.21190@racer> (raw)
In-Reply-To: <1212663163-43064-1-git-send-email-pdebie@ai.rug.nl>
Hi,
On Thu, 5 Jun 2008, Pieter de Bie wrote:
> This adds the --import-marks and --export-marks to fast-export. These
> import and export the marks used to for all revisions exported in a
> similar fashion to what fast-import does. The format is the same as
> fast-import, so you can create a bidirectional importer / exporter by
> using the same marks file on both sides.
Nicely done. As I said, I would like the pointer magic to be wrapped in a
function so that this programmer does not get confused by it again, but
it's not that important. IOW only do it if you agree strongly.
Other than that, ACK.
Ciao,
Dscho
next prev parent reply other threads:[~2008-06-05 13:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 20:55 [PATCH] builtin-fast-export: Add importing and exporting of revision marks Pieter de Bie
2008-06-05 0:00 ` Johannes Schindelin
2008-06-05 10:46 ` Pieter de Bie
2008-06-05 10:52 ` [PATCH v2] " Pieter de Bie
2008-06-05 13:35 ` Johannes Schindelin [this message]
2008-06-06 23:09 ` Junio C Hamano
2008-06-07 13:06 ` Pieter de Bie
2008-06-07 15:19 ` Johannes Schindelin
2008-06-07 16:37 ` Junio C Hamano
2008-06-11 19:45 ` Johannes Schindelin
2008-06-07 13:25 ` [PATCH] Documentation/fast-export: Document --import-marks and --export-marks options Pieter de Bie
2008-06-07 15:20 ` Johannes Schindelin
2008-06-10 6:47 ` Junio C Hamano
2008-06-11 11:17 ` [PATCH v3] builtin-fast-export: Add importing and exporting of revision marks Pieter de Bie
2008-06-11 11:24 ` Pieter de Bie
2008-06-11 18:45 ` Johannes Schindelin
2008-06-11 21:43 ` Junio C Hamano
2008-06-05 13:31 ` [PATCH] " Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0806051433590.21190@racer \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=pdebie@ai.rug.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).