From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Lea Wiemann <lewiemann@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] cat-file --batch / --batch-check: do not exit if hashes are missing
Date: Mon, 9 Jun 2008 02:02:14 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.1.00.0806090201090.1783@racer> (raw)
In-Reply-To: <484C73DA.10804@gmail.com>
Hi,
On Mon, 9 Jun 2008, Lea Wiemann wrote:
> Johannes Schindelin wrote:
> > Lea Wiemann wrote:
> > > - if (type <= 0)
> > > - return 1;
> > > + if (type <= 0) {
> > > + printf("%s missing\n", obj_name);
> > > + fflush(stdout);
> > > + return 0;
> > > + }
> >
> > Is it really intended that it returns 0 now?
>
> Yes, return 0 causes it to not exit (which is the desired effect, as in
> documented).
That is unexpected. IMO this is a bug. rev-parse I can understand, but
cat-file not failing when it clearly did not find the object?
Ciao,
Dscho
next prev parent reply other threads:[~2008-06-09 1:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 23:28 [PATCH] cat-file --batch / --batch-check: do not exit if hashes are missing Lea Wiemann
2008-06-08 23:34 ` Johannes Schindelin
2008-06-09 0:05 ` Lea Wiemann
2008-06-09 1:02 ` Johannes Schindelin [this message]
2008-06-09 10:17 ` Lea Wiemann
2008-06-09 11:07 ` Jakub Narebski
2008-06-09 13:27 ` Lea Wiemann
2008-06-09 0:02 ` [PATCH v2] " Lea Wiemann
2008-06-09 20:37 ` Junio C Hamano
2008-06-09 20:42 ` Junio C Hamano
2008-06-09 14:23 ` [PATCH] " Johannes Sixt
2008-06-09 18:21 ` Lea Wiemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0806090201090.1783@racer \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=lewiemann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox