Re: [PATCH] Add test-tr: poor-man tr

[Johannes Schindelin <Johannes.Schindelin@gmx.de>]

Hi,

On Thu, 12 Jun 2008, Alf Clement wrote:

> > +static unsigned char *unquote(const char *s, unsigned *len) +{
> > +       unsigned char *result = malloc(strlen(s)), *r = result;
> 
> are you sure that the buffer is big enough?? Nomally you do a
> malloc(strlen(s)+1).

AFAIU a "tr" really only ever replaces single characters by single 
characters.  So, not even looking at the code -- just like you -- I would 
expect it to get the exact number of bytes read, and to write the same 
number of bytes.

I certainly would not expect it to do something string based, introducing 
a silly expectation of NUL-terminations (which tr(1) does not expect 
either).

Ciao,
Dscho