From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Don Zickus <dzickus@redhat.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-apply doesn't handle same name patches well [V2]
Date: Tue, 17 Jun 2008 10:30:35 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.1.00.0806171027200.6439@racer> (raw)
In-Reply-To: <1213633441-29185-1-git-send-email-dzickus@redhat.com>
Hi,
On Mon, 16 Jun 2008, Don Zickus wrote:
> Changes since v1
> ================
> - converted to path-list structs
> - added testcases for renaming a patch and apply a new patch on top inside
> the same patch file
Just for future reference: commonly, this is not put into the commit
message, but after the "---" separator into the mail comments.
> +/*
> + * Caches patch filenames to handle the case where a
> + * patch chunk reuses a filename
> + */
> +struct fn_cache {
> + char *name;
> + struct patch *patch;
> + struct fn_cache *next;
> +};
It is still not a path_list. Even if you said so in the "Changes since
V1".
See
http://repo.or.cz/w/git/vmiklos.git?a=blob;f=Documentation/technical/api-path-list.txt;h=9dbedd0a67ce6c1cecd157b0d89f9b1333e180e3;hb=340d6344cfe13bb93740f40d3268ca39b8c7c15d#l36
for a nice example how to use path_lists.
You want to use path_list_has_path().
Hth,
Dscho
next prev parent reply other threads:[~2008-06-17 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 16:24 [PATCH] git-apply doesn't handle same name patches well [V2] Don Zickus
2008-06-17 9:30 ` Johannes Schindelin [this message]
2008-06-17 14:14 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0806171027200.6439@racer \
--to=johannes.schindelin@gmx.de \
--cc=dzickus@redhat.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox