From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <junio@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] builtin-rerere: fix a small leak
Date: Tue, 17 Jun 2008 11:34:29 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.1.00.0806171133330.6439@racer> (raw)
In-Reply-To: <7vk5go7cek.fsf@gitster.siamese.dyndns.org>
Hi,
On Tue, 17 Jun 2008, Junio C Hamano wrote:
> The data read from MERGE_RR file is kept in path-list by hanging textual
> 40-byte conflict signature to path of the blob that contains the
> conflict. The signature is strdup'ed twice, and the second copy is given
> to the path-list, leaking the first copy.
>
> Signed-off-by: Junio C Hamano <junio@pobox.com>
> ---
> * Am I overlooking something obvious, or is this simply a never-reviewed
> buglet that nobody has noticed for a long time?
I think that it was a never-reviewed buglet. The only code path leading
to read_rr passes merge_rr, which has strdup_paths == 1.
Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Ciao,
Dscho
prev parent reply other threads:[~2008-06-17 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 7:23 [PATCH] builtin-rerere: fix a small leak Junio C Hamano
2008-06-17 10:34 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0806171133330.6439@racer \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junio@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox