From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Stephan Beyer <s-beyer@gmx.net>
Cc: git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH 1/3] t3404: slight improvements
Date: Fri, 20 Jun 2008 14:05:30 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.1.00.0806201404020.6439@racer> (raw)
In-Reply-To: <1213929935-15093-2-git-send-email-s-beyer@gmx.net>
Hi,
On Fri, 20 Jun 2008, Stephan Beyer wrote:
> This patch adds some extra checks into some
> test cases and changes "! git ..." into
> "test_must_fail git".
I think your oneline should read "t3404: be more anal".
> diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
> index e6f3fad..daba5fd 100755
> --- a/t/t3404-rebase-interactive.sh
> +++ b/t/t3404-rebase-interactive.sh
> @@ -107,7 +107,8 @@ chmod a+x fake-editor.sh
>
> test_expect_success 'no changes are a nop' '
> git rebase -i F &&
> - test $(git rev-parse I) = $(git rev-parse HEAD)
> + test $(git rev-parse I) = $(git rev-parse HEAD) &&
> + test "$(git symbolic-ref -q HEAD)" = "refs/heads/branch2"
> '
You could have saved some diff-screen-estate by putting the extra check
_before_ the original one.
Other than that, I think this patch is fine.
Ciao,
Dscho
prev parent reply other threads:[~2008-06-20 13:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 2:45 some small changes for rebase-i Stephan Beyer
2008-06-20 2:45 ` [PATCH 1/3] t3404: slight improvements Stephan Beyer
2008-06-20 2:45 ` [PATCH 2/3] rebase-i: slight internal improvements Stephan Beyer
2008-06-20 2:45 ` [PATCH 3/3] Make rebase--interactive use OPTIONS_SPEC Stephan Beyer
2008-06-20 5:48 ` Stephan Beyer
2008-06-20 13:15 ` Johannes Schindelin
2008-06-20 18:30 ` [PATCH 1/2] t3404: extra checks and s/! git/test_must_fail git/ Stephan Beyer
2008-06-20 18:30 ` [PATCH 2/2] Make rebase--interactive use OPTIONS_SPEC Stephan Beyer
2008-06-20 18:48 ` [PATCH 1/2] t3404: extra checks and s/! git/test_must_fail git/ Brandon Casey
2008-06-20 19:00 ` Stephan Beyer
2008-06-20 22:18 ` しらいしななこ
2008-06-21 1:46 ` Stephan Beyer
2008-06-21 9:46 ` Junio C Hamano
2008-06-21 23:55 ` [PATCH v3 1/2] t3404: stricter tests for git-rebase--interactive Stephan Beyer
2008-06-21 23:55 ` [PATCH v3 2/2] Make rebase--interactive use OPTIONS_SPEC Stephan Beyer
2008-06-20 7:16 ` [PATCH 2/3] rebase-i: slight internal improvements Johannes Sixt
2008-06-20 8:01 ` Stephan Beyer
2008-06-20 8:17 ` Johannes Sixt
2008-06-20 12:46 ` Johannes Schindelin
2008-06-20 18:45 ` Stephan Beyer
2008-06-20 13:05 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0806201404020.6439@racer \
--to=johannes.schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=s-beyer@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox