From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Johannes Sixt <j.sixt@viscovery.net>, gitster@pobox.com
Cc: Len Brown <lenb@kernel.org>, git@vger.kernel.org
Subject: Re: [PATCH] commit-tree: lift completely arbitrary limit of 16 parents
Date: Fri, 27 Jun 2008 14:02:47 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.1.00.0806271402110.9925@racer> (raw)
In-Reply-To: <4864E472.3070301@viscovery.net>
Hi,
On Fri, 27 Jun 2008, Johannes Sixt wrote:
> Johannes Schindelin schrieb:
> > @@ -69,18 +63,16 @@ int cmd_commit_tree(int argc, const char **argv, const char *prefix)
> >
> > check_valid(tree_sha1, OBJ_TREE);
> > for (i = 2; i < argc; i += 2) {
> > + unsigned char sha1[40];
>
> unsigned char sha1[20];
>
> is sufficient here, /me thinks.
Ooops. Completely correct.
Junio, want me to fix it up? Or do you want me not to bother with this
patch at all?
Ciao,
Dscho
next prev parent reply other threads:[~2008-06-27 13:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 2:44 octopus limit Len Brown
2008-06-27 6:33 ` Matthieu Moy
2008-06-27 13:04 ` Miklos Vajna
2008-06-27 12:00 ` Johannes Schindelin
2008-06-27 12:24 ` [PATCH] commit-tree: lift completely arbitrary limit of 16 parents Johannes Schindelin
2008-06-27 13:00 ` Johannes Sixt
2008-06-27 13:02 ` Johannes Schindelin [this message]
2008-06-27 17:16 ` Junio C Hamano
2008-06-27 17:46 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0806271402110.9925@racer \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=lenb@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox