Git development
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Don Zickus <dzickus@redhat.com>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] t4127-apply-same-fn: Avoid sed -i
Date: Fri, 4 Jul 2008 19:39:23 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.1.00.0807041938360.9925@racer> (raw)
In-Reply-To: <486DC687.4070307@viscovery.net>

Hi,

On Fri, 4 Jul 2008, Johannes Sixt wrote:

> > When I created the tests for my git-apply patch, I accidently used the 
> > '-i' flag for sed.

Maybe we should modify our hooks so that this is warned about?  While at 
it, we could warn about quoted "wc -l", too...

Ciao,
Dscho

      reply	other threads:[~2008-07-04 18:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-03 16:00 [PATCH] git-apply tests need to be portable Don Zickus
2008-07-04  6:43 ` [PATCH] t4127-apply-same-fn: Avoid sed -i Johannes Sixt
2008-07-04 18:39   ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.0807041938360.9925@racer \
    --to=johannes.schindelin@gmx.de \
    --cc=dzickus@redhat.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.sixt@viscovery.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox