From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Olivier Marin <dkr+ml.git@free.fr>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] builtin-rerere: fix conflict markers parsing
Date: Mon, 7 Jul 2008 16:29:35 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.1.00.0807071627020.18205@racer> (raw)
In-Reply-To: <48722BD9.4090406@free.fr>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 920 bytes --]
Hi,
On Mon, 7 Jul 2008, Olivier Marin wrote:
> Johannes Schindelin a écrit :
> >
> > Okay, but then the obvious question is: what do you do about "<<<<<<"
> > lines that are not a marker?
>
> The answer is the same.
I think not. You say you want to do something about the ambiguity, but
fact is: the conflict markers are ambiguous. They always have been, will
ever be, and I do not even have to argue for it. Or do I?
> > Same remark as before: if you fix rerere, why not do it properly?
>
> If you have a better fix send a patch or at least give me some clues.
Did I not say that the index has enough information? Or at least hint at
it?
Of course, we could run with your solution. But that only fixes a corner
case, right?
So a proper fix will be needed eventually anyway.
And no, I will not work on it: this is not my itch, and my time is being
stolen too much already, these days.
Ciao,
Dscho
next prev parent reply other threads:[~2008-07-07 15:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 12:42 [PATCH] builtin-rerere: fix conflict markers parsing Olivier Marin
2008-07-07 13:02 ` Johannes Schindelin
2008-07-07 13:55 ` Olivier Marin
2008-07-07 14:06 ` Johannes Schindelin
2008-07-07 14:44 ` Olivier Marin
2008-07-07 15:29 ` Johannes Schindelin [this message]
2008-07-07 17:39 ` Junio C Hamano
2008-07-08 7:52 ` Re* " Junio C Hamano
2008-07-08 10:42 ` Olivier Marin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0807071627020.18205@racer \
--to=johannes.schindelin@gmx.de \
--cc=dkr+ml.git@free.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox