From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: [PATCH] Fixed text file auto-detection: treat EOF character 032 at the end of file as printable Date: Fri, 11 Jul 2008 19:42:33 +0100 (BST) Message-ID: References: <7vabh0d4t9.fsf@gitster.siamese.dyndns.org> <1215794896-31354-1-git-send-email-prohaska@zib.de> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Junio C Hamano , git@vger.kernel.org, Dmitry Kakurin To: Steffen Prohaska X-From: git-owner@vger.kernel.org Fri Jul 11 20:44:17 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1KHNag-0003me-1m for gcvg-git-2@gmane.org; Fri, 11 Jul 2008 20:43:34 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754224AbYGKSmg (ORCPT ); Fri, 11 Jul 2008 14:42:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754084AbYGKSmg (ORCPT ); Fri, 11 Jul 2008 14:42:36 -0400 Received: from mail.gmx.net ([213.165.64.20]:46685 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753883AbYGKSmf (ORCPT ); Fri, 11 Jul 2008 14:42:35 -0400 Received: (qmail invoked by alias); 11 Jul 2008 18:42:33 -0000 Received: from grape.st-and.ac.uk (EHLO grape.st-and.ac.uk) [138.251.155.28] by mail.gmx.net (mp007) with SMTP; 11 Jul 2008 20:42:33 +0200 X-Authenticated: #1490710 X-Provags-ID: V01U2FsdGVkX1/gI2dfDG3gEySicZ4oRNKZuS6cJF9lIfbiuVTi0V gTDvHUooB3yQ7O X-X-Sender: gene099@racer In-Reply-To: <1215794896-31354-1-git-send-email-prohaska@zib.de> User-Agent: Alpine 1.00 (DEB 882 2007-12-20) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.53 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Hi, On Fri, 11 Jul 2008, Steffen Prohaska wrote: > From: Dmitry Kakurin > > Signed-off-by: Dmitry Kakurin > Signed-off-by: Steffen Prohaska > --- > convert.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/convert.c b/convert.c > index 352b69d..78efed8 100644 > --- a/convert.c > +++ b/convert.c > @@ -61,6 +61,10 @@ static void gather_stats(const char *buf, unsigned long size, struct text_stat * > else > stats->printable++; > } > + > + /* If file ends with EOF then don't count this EOF as non-printable. */ > + if (size >= 1 && buf[size-1] == '\032') > + stats->nonprintable--; This is one of the things that are very specific to Windows and should not affect other people. Ciao, Dscho P.S.: this is one of the examples why I would like to discuss things that are Windows-only on the msysGit list, until we have a consensus there. We have a few Git experts there, you and Hannes in particular, which cover that side, but also some Windows experts such as Peter and Marius, and we should not need to have that discussion on a list where people are not expected to care about Windows _at all_.