From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: [PATCH 0/4] Honor core.deltaBaseCacheLimit during index-pack Date: Mon, 14 Jul 2008 13:10:47 +0100 (BST) Message-ID: References: <20080713011512.GB31050@spearce.org> <1216001267-33235-1-git-send-email-spearce@spearce.org> <20080714031242.GA14542@spearce.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: "Shawn O. Pearce" , Nicolas Pitre , Junio C Hamano , git@vger.kernel.org, Stephan Hennig , Andreas Ericsson To: Jakub Narebski X-From: git-owner@vger.kernel.org Mon Jul 14 14:12:19 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1KIMuH-0007uY-Iz for gcvg-git-2@gmane.org; Mon, 14 Jul 2008 14:11:54 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752507AbYGNMKz (ORCPT ); Mon, 14 Jul 2008 08:10:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751913AbYGNMKy (ORCPT ); Mon, 14 Jul 2008 08:10:54 -0400 Received: from mail.gmx.net ([213.165.64.20]:42039 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751419AbYGNMKy (ORCPT ); Mon, 14 Jul 2008 08:10:54 -0400 Received: (qmail invoked by alias); 14 Jul 2008 12:10:52 -0000 Received: from grape.st-and.ac.uk (EHLO grape.st-and.ac.uk) [138.251.155.28] by mail.gmx.net (mp066) with SMTP; 14 Jul 2008 14:10:52 +0200 X-Authenticated: #1490710 X-Provags-ID: V01U2FsdGVkX1/1jWFXm9f1yQYvSaxAhfrDCNVuf3H+WdnRRsUImW VZgQquYxO4PKeT X-X-Sender: gene099@racer In-Reply-To: User-Agent: Alpine 1.00 (DEB 882 2007-12-20) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.6899999999999999 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Hi, On Mon, 14 Jul 2008, Jakub Narebski wrote: > Johannes Schindelin writes: > > On Mon, 14 Jul 2008, Shawn O. Pearce wrote: > > > > The only other alternative I can come up with is to change pack-objects > > > (or at least its defaults) so we don't generate these massive delta > > > chains. But there are already packs in the wild that use these chains, > > > resulting in performance problems for clients. > > > > But the long chains make the pack actually as efficient as it is... > > Perhaps Shawn thought here about limiting delta chain not by its > *length*, but by its *size* (as required when unpacking last object > in a delta chanin). So you mean once the sizes of the reconstructed objects are too big, i.e. when the delta chain is actually _most useful_, we should not do it? Don't think so. Ciao, Dscho