From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Johannes Sixt <johannes.sixt@telecom.at>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [PATCH] builtin-clone: Use is_dir_sep() instead of '/'
Date: Sat, 19 Jul 2008 13:35:58 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.1.00.0807191334560.3305@eeepc-johanness> (raw)
In-Reply-To: <200807191132.45648.johannes.sixt@telecom.at>
Hi,
On Sat, 19 Jul 2008, Johannes Sixt wrote:
> On Samstag, 19. Juli 2008, Junio C Hamano wrote:
> > Ok, but the surrounding code in this function look very suspicious.
>
> How about this then?
I like it. Very clear, very nice. Shorter code (if you look at the
diffstat modulo documentation).
Ciao,
Dscho
next prev parent reply other threads:[~2008-07-19 11:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 7:34 [PATCH] Windows related patches Johannes Sixt
2008-07-18 7:34 ` [PATCH] Teach lookup_prog not to select directories Johannes Sixt
2008-07-18 7:34 ` [PATCH] builtin-clone: Use is_dir_sep() instead of '/' Johannes Sixt
2008-07-18 7:34 ` [PATCH] Add ANSI control code emulation for the Windows console Johannes Sixt
2008-07-18 7:34 ` [PATCH] Windows: set gitexecdir = $(bindir) Johannes Sixt
2008-07-19 0:32 ` Junio C Hamano
2008-07-19 8:52 ` Johannes Sixt
2008-07-19 17:10 ` Steffen Prohaska
2008-07-19 17:28 ` Junio C Hamano
2008-07-19 19:31 ` Johannes Sixt
2008-07-19 0:32 ` [PATCH] builtin-clone: Use is_dir_sep() instead of '/' Junio C Hamano
2008-07-19 9:32 ` Johannes Sixt
2008-07-19 11:35 ` Johannes Schindelin [this message]
2008-07-19 13:49 ` Johannes Sixt
2008-07-19 17:44 ` Daniel Barkalow
2008-07-21 13:43 ` Kristian Høgsberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0807191334560.3305@eeepc-johanness \
--to=johannes.schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.sixt@telecom.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox