From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Stephan Beyer <s-beyer@gmx.net>
Cc: SungHyun Nam <namsh@posdata.co.kr>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Fix git-shell build error when NO_SETENV is defined
Date: Mon, 21 Jul 2008 03:23:00 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.1.00.0807210321190.3305@eeepc-johanness> (raw)
In-Reply-To: <1216601017-7871-1-git-send-email-s-beyer@gmx.net>
Hi,
On Mon, 21 Jul 2008, Stephan Beyer wrote:
> If NO_SETENV is defined, git-shell could not be built.
>
> Thanks to SungHyun Nam for the hint.
>
> Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
> ---
>
> This was my mistake. I haven't tested with several build options.
> Now I've tested with
> NO_SETENV=1 NO_EXPAT=1 NO_MEMMEM=1 NO_STRTOUMAX=1 NO_MKDTEMP=1
> NO_SYS_SELECT_H=1 NO_SYMLINK_HEAD=1
> and compat/setenv.o seems to be the only one that was missing.
Funny. It was not 24 hours ago that Hannes reported a related issue. And
he was testing with different options.
His fix to include COMPAT_OBJECTS made much more sense, too, than to pick
selectively a file here and a file there and then hoping that you catch
all.
Ciao,
Dscho
next prev parent reply other threads:[~2008-07-21 1:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 0:29 git-shell build error SungHyun Nam
2008-07-21 0:43 ` [PATCH] Fix git-shell build error when NO_SETENV is defined Stephan Beyer
2008-07-21 1:23 ` Johannes Schindelin [this message]
2008-07-21 1:29 ` Stephan Beyer
2008-07-21 1:33 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0807210321190.3305@eeepc-johanness \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=namsh@posdata.co.kr \
--cc=s-beyer@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox