From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] git add: do not add files from a submodule
Date: Tue, 22 Jul 2008 22:32:03 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.1.00.0807222230490.8986@racer> (raw)
In-Reply-To: <alpine.DEB.1.00.0807210256510.3305@eeepc-johanness>
Hi Junio,
On Mon, 21 Jul 2008, Johannes Schindelin wrote:
> It comes quite as a surprise to an unsuspecting Git user that calling
> "git add submodule/file" (which is a mistake, alright) _removes_
> the submodule in the index, and adds the file. Instead, complain loudly.
>
> While at it, be nice when the user said "git add submodule/" which is
> most likely the consequence of tab-completion, and stage the submodule,
> instead of trying to add the contents of that directory.
Do you plan to apply the split-up builtin-add enhancments you did a few
nights ago, so that this patch can be elegant? I think this fix should go
into 1.6.0.
Ciao,
Dscho
next prev parent reply other threads:[~2008-07-22 21:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 6:09 [PATCH v2 1/4] builtin-add.c: restructure the code for maintainability Junio C Hamano
2008-07-20 6:09 ` [PATCH v2 2/4] git-add --all: add all files Junio C Hamano
2008-07-20 6:09 ` [PATCH v2 3/4] git-add --all: tests Junio C Hamano
2008-07-20 6:09 ` [PATCH v2 4/4] git-add --all: documentation Junio C Hamano
2008-07-21 0:56 ` [PATCH v2 1/4] builtin-add.c: restructure the code for maintainability Johannes Schindelin
2008-07-21 0:58 ` [PATCH/RFC] git add: do not add files from a submodule Johannes Schindelin
2008-07-22 21:32 ` Johannes Schindelin [this message]
2008-07-23 6:40 ` Junio C Hamano
2008-07-23 8:13 ` Pierre Habouzit
2008-07-23 18:31 ` Junio C Hamano
2008-07-23 19:02 ` Pierre Habouzit
2008-07-23 19:10 ` Johannes Schindelin
2008-07-23 19:11 ` Pierre Habouzit
2008-07-21 5:22 ` [PATCH v2 1/4] builtin-add.c: restructure the code for maintainability Junio C Hamano
2008-07-21 7:52 ` Junio C Hamano
2008-07-21 8:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0807222230490.8986@racer \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox