Git development
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Mike Hommey <mh@glandium.org>
Cc: Jonathan Nieder <jrnieder@uchicago.edu>,
	Christian Couder <chriscool@tuxfamily.org>,
	git@vger.kernel.org
Subject: Re: [PATCH v2] t6030 (bisect): work around Mac OS X "ls"
Date: Thu, 24 Jul 2008 18:44:12 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.1.00.0807241842030.8986@racer> (raw)
In-Reply-To: <20080724165434.GA26660@glandium.org>

Hi,

On Thu, 24 Jul 2008, Mike Hommey wrote:

> On Thu, Jul 24, 2008 at 02:43:51AM -0500, Jonathan Nieder wrote:
>
> > Mike Hommey wrote:
> > 
> > > On Thu, Jul 24, 2008 at 07:57:26AM +0200, Christian Couder wrote:
> > >
> > >> +	test -z "$(ls .git/BISECT_*)" &&
> > > 
> > > That is still a useless use of ls ;)
> > 
> > It is much better than what I wrote, at least.
> 
> But could also be written with echo instead of ls.

Sure, but then it looks uglier:

		test ".git/BISECT_*" = "$(echo .git/BISECT_*)" &&

and it is much easier to hide a typo there.

And now the big question: is it performance critical?  Or is obvious 
correctness the highest goal here?

Hth,
Dscho

  reply	other threads:[~2008-07-24 17:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24  1:37 [PATCH] t6030 (bisect): work around Mac OS X "ls" Jonathan Nieder
2008-07-24  5:57 ` Christian Couder
2008-07-24  6:06   ` Mike Hommey
2008-07-24  7:43     ` [PATCH v2] " Jonathan Nieder
2008-07-24 16:54       ` Mike Hommey
2008-07-24 17:44         ` Johannes Schindelin [this message]
2008-07-24 17:51         ` [PATCH v3] " Jonathan Nieder
2008-07-24 18:16           ` Jonathan Nieder
2008-07-27  3:19       ` [PATCH v2] " Christian Couder
2008-07-27  4:04         ` Christian Couder
2008-07-27  4:53           ` Jonathan Nieder
2008-07-27  5:10             ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.0807241842030.8986@racer \
    --to=johannes.schindelin@gmx.de \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@uchicago.edu \
    --cc=mh@glandium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox