Git development
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jon Loeliger <jdl@freescale.com>
Cc: sverre@rabbelier.nl, "Abhijit Menon-Sen" <ams@toroid.org>,
	"Peter Valdemar Mørch" <4ux6as402@sneakemail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] Avoid warning when From: is encoded
Date: Sat, 26 Jul 2008 04:53:30 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.1.00.0807260449490.26810@eeepc-johanness> (raw)
In-Reply-To: <488A01B8.2010405@freescale.com>

Hi,

On Fri, 25 Jul 2008, Jon Loeliger wrote:

> Sverre Rabbelier wrote:
> 
> > Acked-by is reserved for people who are "owners" of the area the patch
> > touches.
> 
> I love pronouncements like this.  While that may be exactly true
> for the Git project, it is not, in general, always true.

It may not be true in general, but from what I heard of the Kernel 
community, even there it is considered rude if you just step in and say 
ACK, when you clearly have no idea what you are talking about (which is 
normally determined by your being involved in that area).

So you can love (or not) pronouncements like that, but the fact still 
stands true: how can your ACK be of any value (or for that matter, how can 
your ACK be taken seriously) when you haven't proven -- in code! -- that 
you understand the code?

Hthab,
Dscho

  reply	other threads:[~2008-07-26  2:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-25 13:06 [PATCH] Avoid warning when From: is encoded Peter Valdemar Mørch
2008-07-25 13:16 ` Abhijit Menon-Sen
2008-07-25 16:01   ` Sverre Rabbelier
2008-07-25 16:39     ` Jon Loeliger
2008-07-26  2:53       ` Johannes Schindelin [this message]
2008-07-25 16:33 ` Junio C Hamano
2008-07-25 18:38   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.0807260449490.26810@eeepc-johanness \
    --to=johannes.schindelin@gmx.de \
    --cc=4ux6as402@sneakemail.com \
    --cc=ams@toroid.org \
    --cc=git@vger.kernel.org \
    --cc=jdl@freescale.com \
    --cc=sverre@rabbelier.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox