From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Miklos Vajna <vmiklos@frugalware.org>
Subject: Re: [RFC/PATCH] merge-base: teach "git merge-base" to accept more than 2 arguments
Date: Sat, 26 Jul 2008 06:25:50 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.1.00.0807260624210.26810@eeepc-johanness> (raw)
In-Reply-To: <20080726055920.3a2fc8e7.chriscool@tuxfamily.org>
Hi,
On Sat, 26 Jul 2008, Christian Couder wrote:
> I suspect this patch may be usefull to simplify my
> "bisect: add merge bases check" series and perhaps
> also generally usefull.
s/usefull/useful/
> diff --git a/builtin-merge-base.c b/builtin-merge-base.c
> index 1cb2925..9c41849 100644
> --- a/builtin-merge-base.c
> +++ b/builtin-merge-base.c
> @@ -2,9 +2,14 @@
> #include "cache.h"
> #include "commit.h"
>
> -static int show_merge_base(struct commit *rev1, struct commit *rev2, int show_all)
> +static struct commit *rev1, **prev2;
> +static size_t prev2_nr, prev2_alloc;
> +
> +
> +static int show_merge_base(int show_all)
> {
Changing the arguments to be static variables?
NACK!
Ciao,
Dscho
next prev parent reply other threads:[~2008-07-26 4:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-26 3:59 [RFC/PATCH] merge-base: teach "git merge-base" to accept more than 2 arguments Christian Couder
2008-07-26 4:25 ` Johannes Schindelin [this message]
2008-07-26 4:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0807260624210.26810@eeepc-johanness \
--to=johannes.schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox