From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Steffen Prohaska <prohaska@zib.de>
Cc: Junio C Hamano <gitster@pobox.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
Johannes Sixt <johannes.sixt@telecom.at>,
git@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] run-command (Windows): Run dashless "git <cmd>" (solves part of problem with system_path)
Date: Tue, 29 Jul 2008 13:13:08 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.1.00.0807291310390.4631@eeepc-johanness> (raw)
In-Reply-To: <42EF8777-BABC-4757-AD49-627320F24D39@zib.de>
Hi,
On Tue, 29 Jul 2008, Steffen Prohaska wrote:
> On Jul 29, 2008, at 7:42 AM, Junio C Hamano wrote:
>
> > We prefer running the dashless form, and POSIX side already does so;
> > we should use it in MinGW's start_command(), too.
>
> Thanks for reading my mind ;-) This was the alternative justification I
> had in mind after reading my patch again.
Well, given that the justification you gave had the obvious flaw -- which
you even pointed out -- that non-builtins are _still_ affected, i.e. that
you leave that bug unfixed (but your description purports that you want to
fix that bug), it would have been wiser to give the alternative
justification, which makes the commit obviously correct.
Ciao,
Dscho
next prev parent reply other threads:[~2008-07-29 11:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BF5B7CBE-ACA8-4D81-8FC0-8A7901205854@zib.de>
2008-07-29 5:17 ` [PATCH 2/2 v2] run-command (Windows): Run dashless "git <cmd>" (solves part of problem with system_path) Steffen Prohaska
2008-07-29 5:17 ` [FOR DEBUGGING] Stop installing BUILT_INS Steffen Prohaska
2008-07-29 5:24 ` [PATCH 2/2 v2] run-command (Windows): Run dashless "git <cmd>" (solves part of problem with system_path) Shawn O. Pearce
2008-07-29 5:42 ` Junio C Hamano
2008-07-29 5:55 ` Steffen Prohaska
2008-07-29 11:13 ` Johannes Schindelin [this message]
2008-07-29 11:31 ` Steffen Prohaska
2008-07-29 5:51 ` Steffen Prohaska
2008-07-29 11:18 ` Johannes Schindelin
2008-07-29 5:15 [Fundamental problem with relative system paths] [PATCH 2/2] run-command (Windows): Run dashless "git <cmd>" Steffen Prohaska
2008-07-29 5:19 ` [PATCH 2/2 v2] run-command (Windows): Run dashless "git <cmd>" (solves part of problem with system_path) Steffen Prohaska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0807291310390.4631@eeepc-johanness \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.sixt@telecom.at \
--cc=prohaska@zib.de \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox