From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Paul Mackerras <paulus@samba.org>,
Alejandro Riveira <ariveira@gmail.com>
Cc: git@vger.kernel.org
Subject: [PATCH] gitk: fix 'can't read "notflag"'
Date: Thu, 4 Dec 2008 15:34:15 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.1.00.0812041532160.7045@racer> (raw)
In-Reply-To: <gh5q1t$qjn$1@ger.gmane.org>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 973 bytes --]
Sometimes, when calling git bisect visualize, parameters including
a "--not" are passed to gitk, triggering an uninitialized-variable bug
introduced in ee66e089(gitk: Make updates go faster).
Noticed by Alejandro Riveira Fernández.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
On Wed, 3 Dec 2008, Alejandro Riveira wrote:
> $ git bisect visualize (03-12 12:16)
> Error in startup script: can't read "notflag": no such variable
Alejandro was good enough to test this fix.
gitk-git/gitk | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 3353f4a..b18bdf0 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -139,6 +139,7 @@ proc parseviewargs {n arglist} {
set origargs $arglist
set allknown 1
set filtered 0
+ set notflag 0
set i -1
foreach arg $arglist {
incr i
--
1.6.0.4.1189.g8876f
next prev parent reply other threads:[~2008-12-04 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 11:20 [BUG] git bisect visualize crash Alejandro Riveira
2008-12-04 14:34 ` Johannes Schindelin [this message]
2008-12-04 15:09 ` [PATCH] gitk: fix 'can't read "notflag"' Johannes Schindelin
2008-12-04 15:59 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0812041532160.7045@racer \
--to=johannes.schindelin@gmx.de \
--cc=ariveira@gmail.com \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox