Git development
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Alexander Gavrilov <angavrilov@gmail.com>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
	Ondrej Certik <ondrej@certik.cz>,
	Git Mailing List <git@vger.kernel.org>,
	Fabian Seoane <fabian@fseoane.net>
Subject: Re: git fast-export | git fast-import doesn't work
Date: Mon, 8 Dec 2008 19:13:33 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.1.00.0812081911550.7516@eeepc-johanness> (raw)
In-Reply-To: <200812071425.52908.angavrilov@gmail.com>

Hi,

On Sun, 7 Dec 2008, Alexander Gavrilov wrote:

> On Wednesday 26 November 2008 20:08:54 Johannes Schindelin wrote:
> > On Wed, 26 Nov 2008, Michael J Gruber wrote:
> > > Looking at the source I suspect that fast-export fails to denote 
> > > parenthood in the case of yet unmarked parents (last for-loop of 
> > > handle_commit() in builtin_fast_export.c). But I don't really know 
> > > that code at all.
> > 
> > I strongly doubt so.  Noticed the use of has_unshown_parent(commit) in 
> > both cases before calling handle_commit()?
> > 
> > In any case, here is a script that I wrote _long_ time ago, to be able 
> > to reconstruct history from the output of "git rev-list --all 
> > --parents".  Maybe this helps you in reconstructing something that is 
> > handled incorrectly by fast-export | fast-import, but is lighter than 
> > a full-blown repository.
> 
> Today I had time to investigate this problem, and found:
> 
> 1) The root of the problem is that fast-export really wants to walk
>     revisions in topological order, but actually receives them in date
>     order.

Indeed.  Can you submit this patch with a proper commit message, adding a 
test for the issue by setting a bogus GIT_COMMITTER_DATE explicitly?

Thanks,
Dscho

  reply	other threads:[~2008-12-08 18:13 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25 16:44 git fast-export | git fast-import doesn't work Ondrej Certik
2008-11-25 17:31 ` Michael J Gruber
2008-11-25 20:41   ` Miklos Vajna
2008-11-25 23:39     ` Ondrej Certik
2008-11-25 23:53       ` david
2008-11-25 23:44   ` Ondrej Certik
2008-11-25 17:34 ` Peter Baumann
2008-11-26  0:14 ` Johannes Schindelin
2008-11-26  9:35   ` Ondrej Certik
2008-11-26 10:18     ` Ondrej Certik
2008-11-26 15:35       ` Michael J Gruber
2008-11-26 15:50         ` Ondrej Certik
2008-11-26 16:35           ` Johannes Sixt
2008-11-27  2:05             ` Ondrej Certik
2009-05-03 19:06             ` Ondrej Certik
2008-11-26 16:40           ` Johannes Schindelin
2008-11-26 16:44             ` Michael J Gruber
2008-11-26 17:08               ` Johannes Schindelin
2008-12-07 11:25                 ` Alexander Gavrilov
2008-12-08 18:13                   ` Johannes Schindelin [this message]
2008-11-26 17:21             ` Ondrej Certik
2008-11-27  8:18               ` Andreas Ericsson
2008-11-26 10:18   ` Michael J Gruber
2008-11-26 12:46     ` Johannes Schindelin
2008-11-26 13:03       ` Ondrej Certik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.0812081911550.7516@eeepc-johanness \
    --to=johannes.schindelin@gmx.de \
    --cc=angavrilov@gmail.com \
    --cc=fabian@fseoane.net \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=ondrej@certik.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox