From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: [PATCH] gitk: force focus to main window Date: Thu, 18 Dec 2008 04:14:25 +0100 (CET) Message-ID: References: <4948E771.4050705@viscovery.net> <18761.29020.237388.687560@cargo.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Johannes Sixt , Git Mailing List To: Paul Mackerras X-From: git-owner@vger.kernel.org Thu Dec 18 04:16:40 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1LD9NP-00027t-Ol for gcvg-git-2@gmane.org; Thu, 18 Dec 2008 04:16:40 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751549AbYLRDPY (ORCPT ); Wed, 17 Dec 2008 22:15:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751521AbYLRDPW (ORCPT ); Wed, 17 Dec 2008 22:15:22 -0500 Received: from mail.gmx.net ([213.165.64.20]:56144 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751487AbYLRDPV (ORCPT ); Wed, 17 Dec 2008 22:15:21 -0500 Received: (qmail invoked by alias); 18 Dec 2008 03:15:19 -0000 Received: from pD9EB2D4F.dip0.t-ipconnect.de (EHLO noname) [217.235.45.79] by mail.gmx.net (mp067) with SMTP; 18 Dec 2008 04:15:19 +0100 X-Authenticated: #1490710 X-Provags-ID: V01U2FsdGVkX18I0G4uEj4IBDc1J8NeYZCsSp6rlBHGbcJcOcEaGM tYSHZQHRFW5ldu X-X-Sender: gene099@racer In-Reply-To: <18761.29020.237388.687560@cargo.ozlabs.ibm.com> User-Agent: Alpine 1.00 (DEB 882 2007-12-20) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.64 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Hi, On Thu, 18 Dec 2008, Paul Mackerras wrote: > Johannes Sixt writes: > > > On msysGit, the focus is first on the (Tk) console. This console is > > then hidden, but keeps the focus. Work around that by forcing the > > focus onto the gitk window. > > Hmmm, I don't like doing focus -force unconditionally on all platforms. > I hate it when applications decide they know best and override what the > window manager decides. >>From my previous experience with my patches to gitk, I did not expect otherwise. That is why I did not even bother with this one. > At least put a if {[tk windowingsystem] eq "win32"} in there. (msysGit > is a windows thing, isn't it?) Yeah, because on other platforms, when you start gitk, you don't want it to take focus. Yeah, right. Ciao, Dscho