From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jake Goulding <goulding@vivisimo.com>
Cc: Miklos Vajna <vmiklos@frugalware.org>, git@vger.kernel.org
Subject: Re: [PATCH] Add --contains flag to git tag
Date: Wed, 21 Jan 2009 09:21:30 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.1.00.0901210919030.7929@racer> (raw)
In-Reply-To: <25058429.247441232510076471.JavaMail.root@scalix.vivisimo.com>
Hi,
On Tue, 20 Jan 2009, Jake Goulding wrote:
> I actually have 1 commit for the code change, one for documentation, and
> one for the test case. Should I squash all these together?
In general, if the patches are not very large and logically belong
together, it is a matter of taste if you squash together documentation and
code changes. Tests, however, belong with the code.
> Also, my test case is in a separate file (t7704-tag-contains.sh) as that
> is how I read t/README. Was this incorrect?
Again, the size matters. If it is a single test case, it is not worth a
whole new file, especially when something like t7004-tag.sh already
exists, whose name just asks for your test case to go in there.
Ciao,
Dscho
next prev parent reply other threads:[~2009-01-21 8:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1232501631-21531-3-git-send-email-goulding@vivisimo.com>
2009-01-21 1:37 ` [PATCH] Add --contains flag to git tag Jake Goulding
2009-01-21 3:20 ` Miklos Vajna
2009-01-21 3:54 ` Jake Goulding
2009-01-21 8:21 ` Johannes Schindelin [this message]
2009-01-22 17:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0901210919030.7929@racer \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=goulding@vivisimo.com \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox