From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Ray Chuan <rctay89@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] http-push: refactor lock-related headers creation for curl requests
Date: Sat, 24 Jan 2009 05:11:21 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.1.00.0901240507070.13232@racer> (raw)
In-Reply-To: <be6fef0d0901231800t6943b01dwbca976d5e9f3397@mail.gmail.com>
Hi,
On Sat, 24 Jan 2009, Ray Chuan wrote:
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Make that an Acked-by:
> + if(options & DAV_HEADER_IF) {
> + strbuf_addf(&buf, "If: (<%s>)", lock->token);
> + dav_headers = curl_slist_append(dav_headers, buf.buf);
> + strbuf_reset(&buf);
BTW in case anyone is puzzled (like I was): curl_slist_append() takes a
"char *" as second parameter, but does not take custody of the buffer;
instead, it strdup()s it. See
http://cool.haxx.se/cvs.cgi/curl/lib/sendf.c?rev=1.155&content-type=text/vnd.viewcvs-markup
for details.
BTNW this should be mentioned in the commit message, too, to spare other
people the puzzlement.
Ciao,
Dscho
next prev parent reply other threads:[~2009-01-24 4:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-24 2:00 [PATCH] http-push: refactor lock-related headers creation for curl requests Ray Chuan
2009-01-24 4:11 ` Johannes Schindelin [this message]
2009-01-24 5:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0901240507070.13232@racer \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox