Git development
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: git@vger.kernel.org,
	"Stephen Haberman" <stephen@exigencecorp.com>,
	spearce@spearce.org, "Thomas Rast" <trast@student.ethz.ch>,
	"Björn Steinbrink" <B.Steinbrink@gmx.de>
Subject: Heads up: major rebase -i -p rework coming up
Date: Sat, 24 Jan 2009 21:25:33 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.1.00.0901242056070.14855@racer> (raw)

Hi all,

as probably everybody agrees, the code to preserve merges is a big mess 
right now.

Worse, the whole concept of "pick <merge-sha1>" just does not fly well.

So I started a _major_ cleanup, which happens to reduce the code very 
nicely so far.

It will take a few days to flesh out, I guess, but these are the major 
ideas of my work:

- pick $sha1

	will only work on non-merges in the future

- merge $sha1 [$sha1...] was $sha1 "Merge ..."

	will merge the given list of commits into the current HEAD, for 
	the user's reference and to keep up-to-date what was rewritten, 
	the original merge is shown after the keyword "was" (which is not 
	a valid SHA-1, luckily)

- goto $sha1

	will reset the HEAD to the given commit

- $sha1'

	for merge and goto, if a $sha1 ends in a single quote, the 
	rewritten commit is substituted (if there is one)

Example:

A - B - - - E 
  \       /
    C - D

could yield this TODO script:

	pick A
	pick C
	pick D
	goto A'
	pick B
	merge D' was E

This should lead to a much more intuitive user experience.

I am very sorry if somebody actually scripted rebase -i -p (by setting 
GIT_EDITOR with a script), but I am very certain that this cleanup is 
absolutely necessary to make rebase -i -p useful.

As always, I am thankful for suggestions to make this even more useful, or 
even easier to operate.

Ciao,
Dscho

             reply	other threads:[~2009-01-24 20:28 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-24 20:25 Johannes Schindelin [this message]
2009-01-24 20:37 ` Heads up: major rebase -i -p rework coming up Junio C Hamano
2009-01-24 21:04   ` Johannes Schindelin
2009-01-24 21:09     ` Johannes Schindelin
2009-01-24 23:01     ` Junio C Hamano
2009-01-25  2:23       ` Johannes Schindelin
2009-01-26 16:21     ` Marc Branchaud
2009-01-24 22:47 ` Thomas Rast
2009-01-25  2:05   ` Johannes Schindelin
2009-01-25  2:25     ` Johannes Schindelin
2009-01-25 13:46       ` Jakub Narebski
2009-01-25 14:17         ` Johannes Schindelin
2009-01-25 15:07           ` Sverre Rabbelier
2009-01-25 15:24             ` Johannes Schindelin
2009-01-25 20:35               ` Junio C Hamano
2009-01-25 20:59                 ` Johannes Schindelin
2009-01-25 22:03                 ` Jakub Narebski
2009-01-25 23:29                   ` Johannes Schindelin
2009-02-03 10:05                     ` Nanako Shiraishi
2009-02-03 11:47                       ` Johannes Schindelin
2009-01-25 16:22           ` Jakub Narebski
2009-01-25 17:18             ` Björn Steinbrink
2009-01-26 16:10 ` Marc Branchaud
2009-01-27 15:21 ` Stephen Haberman
2009-01-27 18:08   ` Johannes Schindelin
2009-01-27 22:10   ` Nanako Shiraishi
2009-01-27 22:36     ` Stephen Haberman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.0901242056070.14855@racer \
    --to=johannes.schindelin@gmx.de \
    --cc=B.Steinbrink@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    --cc=stephen@exigencecorp.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox