From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Sverre Rabbelier <alturin@gmail.com>
Subject: Re: [PATCH] test-lib: write test results to test-results/<basename>-<pid>
Date: Fri, 13 Mar 2009 17:36:13 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.1.00.0903131735110.6288@intel-tinevez-2-302> (raw)
In-Reply-To: <3728317206182c4d4539f3d20b8441cb160e72e3.1236961524u.git.johannes.schindelin@gmx.de>
Hi,
On Fri, 13 Mar 2009, Johannes Schindelin wrote:
> The earlier code meant to attempt to strip everything except the test
> number, but only stripped the part starting with the last dash.
>
> However, there is no reason why we should not use the whole basename.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>
> Even if this is not strictly necessary after Hannes' test cleanup,
> it would still be nice.
Just to clarify: it fixes the issue that these two tests share the same
file in test-results/: t5521-pull-options.sh t5521-pull-symlink.sh
As a consequence, one's results overwrite the other one's.
Ciao,
Dscho
next prev parent reply other threads:[~2009-03-13 16:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1236961524u.git.johannes.schindelin@gmx.de>
2009-03-13 16:26 ` [PATCH] test-lib: write test results to test-results/<basename>-<pid> Johannes Schindelin
2009-03-13 16:36 ` Johannes Schindelin [this message]
2009-03-13 17:20 ` SZEDER Gábor
2009-03-13 17:44 ` SZEDER Gábor
2009-03-14 11:53 ` Johannes Schindelin
2009-03-14 12:16 ` SZEDER Gábor
2009-03-14 12:22 ` Johannes Schindelin
2009-03-14 12:28 ` SZEDER Gábor
2009-03-14 13:16 ` Sverre Rabbelier
2009-03-14 13:59 ` SZEDER Gábor
2009-03-16 10:18 ` Johannes Schindelin
2009-03-16 10:41 ` SZEDER Gábor
2009-03-13 17:20 ` Junio C Hamano
2009-03-13 17:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0903131735110.6288@intel-tinevez-2-302 \
--to=johannes.schindelin@gmx.de \
--cc=alturin@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox