From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v3 0/4] Teach 'git grep' about --open-files-in-pager=[<pager>]
Date: Sat, 12 Jun 2010 23:36:02 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.1.00.1006122335190.2689@bonsai2> (raw)
In-Reply-To: <20100612162945.GB1406@burratino>
Hi,
On Sat, 12 Jun 2010, Jonathan Nieder wrote:
> Johannes Schindelin wrote:
>
> > Nope, the patch is still there, even after a rebase.
>
> Ah, I see. Looks like a good patch (d00d655, Unify code paths of
> threaded greps, 2010-02-07) though in principle a separate topic, since
> grep -O already sets use_threads = 0.
No. It applies without the patch. But in my tests, it just does not work
on multi-core machines without the patch.
Ciao,
Dscho
next prev parent reply other threads:[~2010-06-12 21:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 0:51 [PATCH v2 0/2] Teach 'git grep' about --open-files-in-pager=[<pager>] Jonathan Nieder
2010-06-05 0:53 ` [PATCH 1/2] grep: Add the option '--open-files-in-pager' Jonathan Nieder
2010-06-05 1:40 ` Jonathan Nieder
2010-06-05 0:55 ` [PATCH 2/2] grep -O: allow optional argument specifying the pager (or editor) Jonathan Nieder
2010-06-05 16:11 ` [PATCH v2 0/2] Teach 'git grep' about --open-files-in-pager=[<pager>] Johannes Schindelin
2010-06-12 7:55 ` Jonathan Nieder
2010-06-12 9:46 ` Johannes Schindelin
2010-06-12 16:29 ` [PATCH v3 0/4] " Jonathan Nieder
2010-06-12 16:31 ` [PATCH 1/4] grep: refactor grep_objects loop into its own function Jonathan Nieder
2010-06-12 16:32 ` [PATCH 2/4] Unify code paths of threaded greps Jonathan Nieder
2010-06-12 16:36 ` [PATCH 3/4] grep: Add the option '--open-files-in-pager' Jonathan Nieder
2010-06-12 16:39 ` [PATCH 4/4] grep -O: allow optional argument specifying the pager (or editor) Jonathan Nieder
2010-06-12 17:16 ` Paolo Bonzini
2010-06-13 16:35 ` Junio C Hamano
2010-06-13 17:04 ` Paolo Bonzini
2010-06-14 6:31 ` Jonathan Nieder
2010-06-12 21:36 ` Johannes Schindelin [this message]
2010-06-12 22:12 ` [PATCH v3 0/4] Teach 'git grep' about --open-files-in-pager=[<pager>] Jonathan Nieder
2010-06-12 11:38 ` [PATCH v2 0/2] " Paolo Bonzini
2010-06-12 14:50 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.1006122335190.2689@bonsai2 \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox