From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jakob Pfender <jpfender@elegosoft.com>,
git@vger.kernel.org, lee.marlow@gmail.com,
markus.heidelberg@web.de, szeder@ira.uka.de, spearce@spearce.org,
bebarino@gmail.com, ted@tedpavlic.com, tlikonen@iki.fi,
trast@student.ethz.ch
Subject: Re: [PATCH] git-completion: Add git help completion for aliases
Date: Tue, 22 Mar 2011 09:44:46 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.1.00.1103220943200.1561@bonsai2> (raw)
In-Reply-To: <7v4o6vmvzs.fsf@alter.siamese.dyndns.org>
Hi,
On Tue, 22 Mar 2011, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> >> > diff --git a/contrib/completion/git-completion.bash
> >> > b/contrib/completion/git-completion.bash
> >> > index 893b771..f9a74d3 100755
> >> > --- a/contrib/completion/git-completion.bash
> >> > +++ b/contrib/completion/git-completion.bash
> >> > @@ -1506,7 +1506,7 @@ _git_help ()
> >> > ;;
> >> > esac
> >> > __git_compute_all_commands
> >> > - __gitcomp "$__git_all_commands
> >> > + __gitcomp "$__git_all_commands $(__git_aliases)
> >> > attributes cli core-tutorial cvs-migration
> >> > diffcore gitk glossary hooks ignore modules
> >> > repository-layout tutorial tutorial-2
> >>
> >> This patch may not be _wrong_ per-se, but it it useful in practice?
> >>
> >> I dunno.
> >>
> >> Don't people usually use aliases so that they do not have to type long
> >> command names that would need completion?
> >
> > Yes. And if you use a lot of aliases, or a lot of machines with evolving
> > aliases, the easiest way to inspect the alias is "git help <alias>". Not
> > seeing it completed is an unexpected behavior.
>
> I've queued the patch and I already said that this is not wrong, but I
> think your argument cuts it both ways.
>
> I have "co" aliased to "checkout", but with this change "git help
> co<TAB>" now will interfere with my expectation that it would complete
> to commit, config and the like, but exclude an alias that I myself
> defined and know how to spell but forgot what its exact definition was,
> in order to avoid cluttering the choices offered.
In a corporate environment, one would now do a market research as to what
is the common expectation.
> This is a constructive tangent but if we are going to run
> $(__git_aliases) every time we run _git_help, perhaps it would want a
> hack similar to the way the value for $__git_all_commands is generated
> just once?
Indeed.
Ciao,
Johannes
next prev parent reply other threads:[~2011-03-22 8:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 9:25 [PATCH] git-completion: Add git help completion for aliases Jakob Pfender
2011-03-21 21:48 ` Junio C Hamano
2011-03-21 22:07 ` Johannes Schindelin
2011-03-22 7:53 ` Junio C Hamano
2011-03-22 8:44 ` Johannes Schindelin [this message]
2011-03-22 8:50 ` SZEDER Gábor
2011-03-22 9:16 ` Erik Faye-Lund
2011-03-22 9:18 ` Erik Faye-Lund
2011-03-22 10:09 ` SZEDER Gábor
2011-03-22 10:28 ` Erik Faye-Lund
2011-03-22 16:38 ` Michael J Gruber
2011-03-22 20:25 ` SZEDER Gábor
2011-03-23 10:32 ` Erik Faye-Lund
2011-03-23 12:11 ` Jakub Narebski
2011-03-23 12:16 ` Erik Faye-Lund
2011-03-22 17:25 ` Junio C Hamano
2011-03-22 21:21 ` SZEDER Gábor
2011-03-22 8:23 ` SZEDER Gábor
2011-03-22 9:23 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.1103220943200.1561@bonsai2 \
--to=johannes.schindelin@gmx.de \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jpfender@elegosoft.com \
--cc=lee.marlow@gmail.com \
--cc=markus.heidelberg@web.de \
--cc=spearce@spearce.org \
--cc=szeder@ira.uka.de \
--cc=ted@tedpavlic.com \
--cc=tlikonen@iki.fi \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox