From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Remove unused variables
Date: Tue, 22 Mar 2011 19:42:06 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.1.00.1103221940050.1561@bonsai2> (raw)
In-Reply-To: <7v39mfkons.fsf@alter.siamese.dyndns.org>
Hi,
On Tue, 22 Mar 2011, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>
> > Noticed by gcc 4.6.0.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
>
> Thanks.
>
> I'll cherry pick only some bits, not because the changes in this patch
> are wrong, but because I know some areas are in flux and I don't want to
> deal with merge conflicts of the "one side fixed a small bug, the other
> side majorly rewrote it and made the bug irrelevant" kind.
Understandable. I will have to deal with the merge conflicts, though, as I
am stuck with 4.6.0 (and self-imposed -Werror, as you might remember) for
the 64-bit Windows build. So I will keep the remains of the patch after
rebasing in our 'devel' branch.
Ciao,
Johannes
next prev parent reply other threads:[~2011-03-22 18:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 12:49 [PATCH 0/2] Fix issues found by gcc 4.6.0 Johannes Schindelin
2011-03-22 12:50 ` [PATCH 1/2] Remove unused variables Johannes Schindelin
2011-03-22 18:15 ` Junio C Hamano
2011-03-22 18:42 ` Johannes Schindelin [this message]
2011-03-22 19:43 ` Jonathan Nieder
2011-03-22 12:50 ` [PATCH 2/2] Actually use retval Johannes Schindelin
2011-03-22 18:10 ` Junio C Hamano
2011-03-22 18:20 ` Johannes Schindelin
2011-03-23 1:26 ` [PATCH 0/2] " Jonathan Nieder
2011-03-23 1:28 ` [PATCH 1/2] tree-diff: make diff_tree return void Jonathan Nieder
2011-03-23 1:30 ` [PATCH 2/2] tree-diff: make diff_tree_sha1 " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.1103221940050.1561@bonsai2 \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox