Git development
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: David Aguilar <davvid@gmail.com>
Cc: Pat Thoyts <patthoyts@users.sourceforge.net>,
	Git <git@vger.kernel.org>, Paul Mackerras <paulus@samba.org>,
	msysGit <msysgit@googlegroups.com>
Subject: Re: [msysGit] [PATCH] gitk: fix the display of files when filtered by path
Date: Thu, 15 Dec 2011 10:24:24 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.1.00.1112151023280.2615@bonsai2> (raw)
In-Reply-To: <CAJDDKr6rVaX_=SZZeEAs950yuNDvi8sOkzrUK7LnCrK6MYfscg@mail.gmail.com>

Hi,

On Wed, 14 Dec 2011, David Aguilar wrote:

> On Tue, Dec 13, 2011 at 8:50 AM, Pat Thoyts
> <patthoyts@users.sourceforge.net> wrote:
> > Launching 'gitk -- .' or 'gitk -- ..\t' restricts the display to files
> > under the given directory but the file list is left empty. This is because
> > the path_filter function fails to match the filenames which are relative
> > to the working tree to the filter which is filessytem relative.
> > This solves the problem by making both names fully qualified filesystem
> > paths before performing the comparison.
> >
> > Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
> 
> Wonderful!

Thanks for reminding me that I did not yet apply and push. Did so now.

Thanks, Pat, for fixing this bug!
Dscho

  reply	other threads:[~2011-12-15  9:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-13 16:50 [PATCH] gitk: fix the display of files when filtered by path Pat Thoyts
2011-12-15  4:18 ` [msysGit] " David Aguilar
2011-12-15  9:24   ` Johannes Schindelin [this message]
2011-12-15 19:42     ` Martin von Zweigbergk
2011-12-15 19:50       ` Junio C Hamano
2011-12-15 22:06         ` Pat Thoyts
2011-12-16 22:27           ` Jakub Narebski
2011-12-15 23:01         ` Paul Mackerras
2011-12-15 21:33       ` Pat Thoyts
2011-12-15 22:59       ` Paul Mackerras
2011-12-17  6:31         ` Junio C Hamano
2012-03-18 23:11 ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.1112151023280.2615@bonsai2 \
    --to=johannes.schindelin@gmx.de \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=msysgit@googlegroups.com \
    --cc=patthoyts@users.sourceforge.net \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox