From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Clemens Buchacher <drizzd@aon.at>,
Junio C Hamano <gitster@pobox.com>,
dfowler <davidfowl@gmail.com>,
git@vger.kernel.org, msysgit@googlegroups.com,
Paul Betts <paul@github.com>, David Ebbo <david.ebbo@gmail.com>
Subject: Re: Re: 1.7.10 doesn't show file pushstatus
Date: Wed, 2 May 2012 03:04:20 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.1.00.1205020301560.27828@bonsai2> (raw)
In-Reply-To: <20120501084048.GA21904@sigill.intra.peff.net>
Hi Peff,
On Tue, 1 May 2012, Jeff King wrote:
> On Tue, May 01, 2012 at 03:33:26AM -0400, Jeff King wrote:
>
> > In this case, send pack gets its arguments from the command-line, not
> > from the options set at the transport layer. Remote-curl will pass along
> > "--quiet" if we get that from the transport layer, but it does not
> > otherwise pass along the "progress" flag. So there are two problems:
> >
> > 1. send-pack defaults its progress boolean to 0. Before 01fdc21, that
> > was OK, because it meant "don't explicitly ask for progress". But
> > after 01fdc21 that now means "explicitly ask for no progress", and
> > the direct-transport code paths were updated without updating
> > cmd_send_pack.
> >
> > 2. There's no way to tell send-pack explicitly "yes, I would like
> > progress, no matter what isatty(2) says". I doubt anybody cares
> > much, but it probably makes sense to handle that for the sake of
> > completeness.
>
> The following patch series fixes this:
>
> [1/3]: send-pack: show progress when isatty(2)
> [2/3]: teach send-pack about --[no-]progress
> [3/3]: t5541: test more combinations of --progress
Thanks. I applied and pushed it after testing on Linux.
David, if you want to relieve me of maintenance burden in the future, you
# apply the patches
# push them to a fork on GitHub
# run the tests
# report back to the mailing list (including the outcome of the test --
detailed, if it fails)
Ciao,
Johannes
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
prev parent reply other threads:[~2012-05-02 1:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120501010609.GA14715@jupiter.local>
2012-05-01 6:58 ` 1.7.10 doesn't show file pushstatus Jeff King
2012-05-01 7:33 ` Jeff King
2012-05-01 8:40 ` Jeff King
2012-05-01 8:41 ` [PATCH 1/3] send-pack: show progress when isatty(2) Jeff King
2012-05-01 8:42 ` [PATCH 2/3] teach send-pack about --[no-]progress Jeff King
2012-05-01 8:43 ` [PATCH 3/3] t5541: test more combinations of --progress Jeff King
2012-05-01 9:35 ` Clemens Buchacher
2012-05-01 9:37 ` Jeff King
2012-05-01 17:53 ` David Ebbo
2012-05-01 20:45 ` Zbigniew Jędrzejewski-Szmek
2012-05-01 20:53 ` Junio C Hamano
2012-05-01 9:32 ` 1.7.10 doesn't show file pushstatus Clemens Buchacher
2012-05-01 17:33 ` Junio C Hamano
2012-05-02 1:04 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.1205020301560.27828@bonsai2 \
--to=johannes.schindelin@gmx.de \
--cc=david.ebbo@gmail.com \
--cc=davidfowl@gmail.com \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
--cc=paul@github.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox