From: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jeff King" <peff@peff.net>,
"Martin von Zweigbergk" <martin.von.zweigbergk@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
git@vger.kernel.org
Subject: Re: bug? in checkout with ambiguous refnames
Date: Sun, 9 Jan 2011 11:18:09 -0500 (EST) [thread overview]
Message-ID: <alpine.DEB.1.10.1101090847120.12031@debian> (raw)
In-Reply-To: <7v1v4m8reh.fsf@alter.siamese.dyndns.org>
On Sat, 8 Jan 2011, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > On Sat, Jan 08, 2011 at 03:40:33PM -0500, Martin von Zweigbergk wrote:
> >
> >> > Yeah, we generally resolve ambiguities in favor of the tag (and that
> >> > warning comes from deep within get_sha1_basic). So the real bug here is
> >> > that it still said "Switched to branch", which is totally wrong.
> >> >
> >> > That being said, it probably would make more sense for "git checkout" to
> >> > prefer branches to tags.
> >>
> >> What was the rationale for generally favoring tags?
> >
> > I don't recall hearing any specific argument, but it has always been
> > that way from early on. I think it is from a vague sense of "tags are
> > more important than branch tips because they are about marking specific
> > points, not lines of development". But maybe other old-timers can say
> > more.
> >
> Aside from your "'checkout branch' is about checking out a branch"
> explanation, there are two reasons to favor branches over tags in
> "checkout" command:
>
> (1) You cannot disambiguate "git checkout heads/master" when you have
> "master" tag, as this notation is used to tell the command "I want to
> detach HEAD at that commit"; and
Interesting. I had no idea that 'git checkout heads/master' means to
detach the HEAD. Thanks.
By analogy, I guess that means that 'git rebase master heads/topic' is
supposed to rebase a detached HEAD, so I will stop trying to "fix"
that then :-)
> (2) The command already treats an unadorned branch name specially by not
> complaining ref/path ambiguity when you said "git checkout master"
> and you have a file called "master" in your working tree, so users
> already expect that an unadorned branch name is special to it.
If I understand correctly, that actually applies to tags as well.
Checking out a tag called e.g. Makefile doesn't give any warnings or
errors.
/Martin
next prev parent reply other threads:[~2011-01-09 16:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 10:46 bug? in checkout with ambiguous refnames Uwe Kleine-König
2011-01-07 19:44 ` Junio C Hamano
2011-01-07 19:49 ` Jeff King
2011-01-07 19:54 ` Jeff King
2011-01-07 22:50 ` Junio C Hamano
2011-01-07 23:17 ` Junio C Hamano
2011-01-11 6:52 ` Jeff King
2011-01-11 17:02 ` Junio C Hamano
2011-01-11 18:02 ` Jeff King
2011-01-12 1:25 ` Jeff King
2011-01-12 9:07 ` Junio C Hamano
2011-01-12 17:27 ` Jeff King
2011-01-11 6:55 ` Jeff King
2011-01-11 19:20 ` Jeff King
2011-01-11 20:00 ` Jeff King
2011-01-08 20:40 ` Martin von Zweigbergk
2011-01-08 21:40 ` Jeff King
2011-01-09 2:43 ` Martin von Zweigbergk
2011-01-09 7:31 ` Junio C Hamano
2011-01-09 16:18 ` Martin von Zweigbergk [this message]
2011-01-12 9:11 ` Uwe Kleine-König
2011-01-12 17:46 ` Jeff King
2011-01-12 18:19 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1101090847120.12031@debian \
--to=martin.von.zweigbergk@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox