git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Olszewski <cxreg@pobox.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fix for incorrect index update
Date: Sat, 9 May 2009 21:46:15 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.0905092139050.21000@narbuckle.genericorp.net> (raw)
In-Reply-To: <7vskjd4mfh.fsf@alter.siamese.dyndns.org>

On Sat, 9 May 2009, Junio C Hamano wrote:

> Thanks.  I'd add:
>
> 	From: Dave Olszewski <cxreg@pobox.com>
>
> at the beginning, so you would not be shown as "Dave O" in "git shortlog"
> and friends.

Ok, sounds good.  Thanks for the explanation of the issue.  Much of the
git internals are still mysterious but that's slowly changing :-)

> Much nicer than Dscho's ;-)

Well, it was mine first, can't fault him for that!

> You inherited a bug from Dscho's patch, it seems.  Have you tried running
> the test with debug option?
>
> This could have been
>
> 	test_debug "echo create a bunch of files" &&
>
> but I'd say we just make them into comments.

I didn't, sorry for that.  Making them comments seems ok to me.

Thanks once again.

     Dave Olszewski

      reply	other threads:[~2009-05-10  4:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-09 21:49 [PATCH] fix for incorrect index update Dave O
2009-05-10  4:22 ` Junio C Hamano
2009-05-10  4:46   ` Dave Olszewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.0905092139050.21000@narbuckle.genericorp.net \
    --to=cxreg@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).