From: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/2] remote: write correct fetch spec when renaming remote 'remote'
Date: Thu, 1 Sep 2011 20:02:53 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1109011945560.7066@debian> (raw)
In-Reply-To: <20110901024211.GC31838@sigill.intra.peff.net>
On Wed, 31 Aug 2011, Jeff King wrote:
> On Wed, Aug 31, 2011 at 09:50:42PM -0400, Martin von Zweigbergk wrote:
>
> > Reduce the risk of changing incorrect sections of the refspec by
> > requiring the string to be matched to have leading and trailing
> > slashes, i.e. match "/<name>/" instead of just "<name>".
>
> Doesn't this just mean that:
>
> git remote rename remotes foo
>
> will break in the same way?
Yes, "r", "ead" and such now work and only exactly "refs", "heads" and
"remotes" don't work. Sorry, forgot to mention that in the commit
message.
> > We could have required even a leading ":refs/remotes/", but that would
> > mean that we would limit the types of refspecs we could help the user
> > update.
>
> Actually, I think it's better to be more conservative [...]
I think you are right. That's what I did (match all the way from
"refs/...") at first, but then I thought that maybe the reason the
matching was relaxed was to allow non-default refspecs. However, as
you point out in the footnote to your reply to PATCH 2/2, that case is
not working consistently anyway, so it seems safe (w.r.t. backwards
compatibility too) to ignore it. Will switch back to matching
":refs/remotes/$OLD".
Martin
prev parent reply other threads:[~2011-09-02 0:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 1:50 [PATCH 1/2] remote: write correct fetch spec when renaming remote 'remote' Martin von Zweigbergk
2011-09-01 1:50 ` [PATCH 2/2] remote: "rename o foo" should not rename ref "origin/bar" Martin von Zweigbergk
2011-09-01 2:46 ` Jeff King
2011-09-02 0:35 ` Martin von Zweigbergk
2011-09-02 15:55 ` Jeff King
2011-09-01 2:42 ` [PATCH 1/2] remote: write correct fetch spec when renaming remote 'remote' Jeff King
2011-09-01 3:18 ` Junio C Hamano
2011-09-02 0:02 ` Martin von Zweigbergk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1109011945560.7066@debian \
--to=martin.von.zweigbergk@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox