git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/4] Always release pack files before calling gc --auto
Date: Wed, 13 Jan 2016 19:52:05 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1601131951040.2964@virtualbox> (raw)
In-Reply-To: <20160113175237.GA13139@sigill.intra.peff.net>

Hi Peff,

On Wed, 13 Jan 2016, Jeff King wrote:

> On Wed, Jan 13, 2016 at 06:20:02PM +0100, Johannes Schindelin wrote:
> 
> > These patches are companions to 786b150 (clone --dissociate: avoid
> > locking pack files, 2015-10-06), triggered by a bug report to the Git
> > for Windows project.
> > 
> > Johannes Schindelin (4):
> >   fetch: release pack files before garbage-collecting
> >   am: release pack files before garbage-collecting
> >   merge: release pack files before garbage-collecting
> >   receive-pack: release pack files before garbage-collecting
> 
> [...]
>
> I think all of the cases here are fine, for two reasons:
> 
>   1. The new closing is right before the program would exit anyway, so
>      there's no interesting work left to do (and obviously that's where
>      we generally want to call "gc --auto", too)

This is actually what I checked, but of course I managed to forget to
mention it in the cover letter :-(

Thanks for verifying, and for spelling it out.
Dscho

      reply	other threads:[~2016-01-13 18:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-13 17:20 [PATCH 0/4] Always release pack files before calling gc --auto Johannes Schindelin
2016-01-13 17:20 ` [PATCH 1/4] fetch: release pack files before garbage-collecting Johannes Schindelin
2016-01-13 17:20 ` [PATCH 2/4] am: " Johannes Schindelin
2016-01-13 17:20 ` [PATCH 3/4] merge: " Johannes Schindelin
2016-01-13 17:20 ` [PATCH 4/4] receive-pack: " Johannes Schindelin
2016-01-13 17:52 ` [PATCH 0/4] Always release pack files before calling gc --auto Jeff King
2016-01-13 18:52   ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1601131951040.2964@virtualbox \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).