From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: tboegi@web.de
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] t0060: basename("//") is implementation defined
Date: Thu, 14 Jan 2016 08:00:24 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1601140758420.2964@virtualbox> (raw)
In-Reply-To: <1452718561-32226-1-git-send-email-tboegi@web.de>
Hi Torsten,
On Wed, 13 Jan 2016, tboegi@web.de wrote:
> diff --git a/test-path-utils.c b/test-path-utils.c
> index 4ab68ac..db0bb39 100644
> --- a/test-path-utils.c
> +++ b/test-path-utils.c
> @@ -142,7 +142,9 @@ static struct test_data dirname_data[] = {
> { ".", "." },
> { "..", "." },
> { "/", "/" },
> +#if defined(NO_LIBGEN_H)
> { "//", "//" },
> +#endif
This would miss faulty implementations that return completely bogus
outputs for the "//" input. Not very likely, I agree, but the entire
intention of this regression test is to verify that Git's expectations are
met (and to document those expectations).
I hope you like the alternative patch I just sent out.
Ciao,
Dscho
next prev parent reply other threads:[~2016-01-14 7:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 20:56 [PATCH/RFC] t0060: basename("//") is implementation defined tboegi
2016-01-13 21:16 ` Junio C Hamano
2016-01-14 7:00 ` Johannes Schindelin [this message]
2016-01-14 11:47 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1601140758420.2964@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).