From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
git@vger.kernel.org, Stefan Beller <sbeller@google.com>,
Guillaume Pages <guillaume.pages@ensimag.grenoble-inp.fr>
Subject: Re: [PATCH] status: be prepared for not-yet-started interactive rebase
Date: Fri, 22 Jan 2016 20:02:45 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1601222000040.2964@virtualbox> (raw)
In-Reply-To: <xmqqio2lv4rg.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Fri, 22 Jan 2016, Junio C Hamano wrote:
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
> > Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> >
> >> wt-status.c | 22 +++++++++++++++-------
> >> 1 file changed, 15 insertions(+), 7 deletions(-)
> >
> > Looks good to me. You may want to add a test by overriding $EDITOR to a
> > script doing "git status >actual" if you want to have fun with testing.
>
> I am unhappy that the code does not read 'rebase-todo' at all when
> 'done' is missing.
At this point is virtually certain that the edit script is opened in an
editor, and very likely to change. So it makes little sense to look at the
todo.
Ciao,
Dscho
next prev parent reply other threads:[~2016-01-22 19:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 16:28 [PATCH] status: be prepared for not-yet-started interactive rebase Johannes Schindelin
2016-01-22 16:45 ` Matthieu Moy
2016-01-22 17:11 ` Johannes Schindelin
2016-01-22 18:38 ` Junio C Hamano
2016-01-22 19:02 ` Johannes Schindelin [this message]
2017-01-26 16:08 ` [PATCH v2 0/1] Let `git status` handle a not-yet-started `rebase -i` gracefully Johannes Schindelin
2017-01-26 16:08 ` [PATCH v2 1/1] status: be prepared for not-yet-started interactive rebase Johannes Schindelin
2017-01-26 18:02 ` Stefan Beller
2017-01-27 10:49 ` Johannes Schindelin
2017-01-26 18:04 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1601222000040.2964@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=guillaume.pages@ensimag.grenoble-inp.fr \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).