From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>, Duy Nguyen <pclouds@gmail.com>,
Karsten Blees <blees@dcon.de>
Cc: John Keeping <john@keeping.me.uk>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] git config: do not create .git/ if it does not exist yet
Date: Wed, 24 Feb 2016 13:13:39 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1602241309560.3152@virtualbox> (raw)
In-Reply-To: <alpine.DEB.2.20.1602241230120.3152@virtualbox>
Hi,
On Wed, 24 Feb 2016, Johannes Schindelin wrote:
> I created a test and essentially duplicated Peff's finding: this is a
> Windows-only issue.
Indeed it is in our patches:
https://github.com/git-for-windows/git/commit/3a4c37b22
(short version: we carry some patches that simplify locking the config
file before building on top of it, and somehow we agreed back in the days
when this patch was written that it would be a good idea if that code
created leading directories.)
I will fix this issue in Git for Windows, but I still think that my patch
brings a usability improvement: the error message is just so much more to
the point (will submit v2 in a moment).
Ciao,
Dscho
next prev parent reply other threads:[~2016-02-24 12:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 7:47 [PATCH] git config: do not create .git/ if it does not exist yet Johannes Schindelin
2016-02-24 8:26 ` Jeff King
2016-02-24 10:14 ` John Keeping
2016-02-24 10:31 ` Jeff King
2016-02-24 11:31 ` Johannes Schindelin
2016-02-24 12:13 ` Johannes Schindelin [this message]
2016-02-24 12:34 ` Jeff King
2016-02-24 18:45 ` Junio C Hamano
2016-02-24 11:01 ` Duy Nguyen
2016-02-24 12:48 ` [PATCH v2] git config: report when trying to modify a non-existing repo config Johannes Schindelin
2016-02-24 12:59 ` Duy Nguyen
2016-02-24 13:26 ` Johannes Schindelin
2016-02-24 13:29 ` Duy Nguyen
2016-02-24 20:11 ` Junio C Hamano
2016-02-24 22:31 ` Junio C Hamano
2016-02-25 15:54 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1602241309560.3152@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=blees@dcon.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).