Re: [PATCH v2] git config: report when trying to modify a non-existing repo config

[Johannes Schindelin <Johannes.Schindelin@gmx.de>]

Hi Junio,

On Wed, 24 Feb 2016, Junio C Hamano wrote:

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> >
> >> diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh
> >> index 91235b7..f62409e 100755
> >> --- a/t/t1308-config-set.sh
> >> +++ b/t/t1308-config-set.sh
> >> @@ -218,4 +218,13 @@ test_expect_success 'check line errors for malformed values' '
> >>  	test_i18ngrep "fatal: .*alias\.br.*\.git/config.*line 2" result
> >>  '
> >>  
> >> +test_expect_success 'error on modifying repo config without repo' '
> >> +	mkdir no-repo &&
> >> +	GIT_CEILING_DIRECTORIES=$(pwd) &&
> >> +	export GIT_CEILING_DIRECTORIES &&
> >> +	cd no-repo &&
> >> +	test_must_fail git config a.b c 2>err &&
> >> +	grep "not in a git directory" err
> >> +'
> >> +
> >>  test_done
> >
> > Please make it a habit to run tests that go up/down in the hierarchy
> > in a subshell.  It is not a good excuse that this new test happens
> > to be at the end _right now_.
> 
> I'd squash this in.

Please do, unless you want me to resend with the squashed commit (I picked
up the change from your 'pu' branch)?

Ciao,
Dscho