From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Dennis Kaarsemaker <dennis@kaarsemaker.net>,
Christian Couder <christian.couder@gmail.com>,
git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] t9700: fix test for perl older than 5.14
Date: Fri, 4 Mar 2016 17:21:27 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1603041720550.3152@virtualbox> (raw)
In-Reply-To: <20160304114321.GA569@sigill.intra.peff.net>
Hi Peff,
On Fri, 4 Mar 2016, Jeff King wrote:
> Subject: t9700: fix test for perl older than 5.14
>
> Commit d53c2c6 (mingw: fix t9700's assumption about
> directory separators, 2016-01-27) uses perl's "/r" regex
> modifier to do a non-destructive replacement on a string,
> leaving the original unmodified and returning the result.
>
> This feature was introduced in perl 5.14, but systems with
> older perl are still common (e.g., CentOS 6.5 still has perl
> 5.10). Let's work around it by providing a helper function
> that does the same thing using older syntax.
>
> While we're at it, let's switch to using an alternate regex
> separator, which is slightly more readable.
My apologies! And thanks for cleaning up after me.
Ciao,
Dscho
next prev parent reply other threads:[~2016-03-04 16:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 8:13 t9700-perl-git.sh is broken on some configurations Christian Couder
2016-03-04 8:56 ` Jeff King
2016-03-04 10:30 ` Christian Couder
2016-03-04 11:45 ` Jeff King
2016-03-04 10:58 ` Dennis Kaarsemaker
2016-03-04 11:43 ` [PATCH] t9700: fix test for perl older than 5.14 Jeff King
2016-03-04 12:21 ` Dennis Kaarsemaker
2016-03-04 20:12 ` Christian Couder
2016-03-04 16:21 ` Johannes Schindelin [this message]
2016-03-04 18:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1603041720550.3152@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=christian.couder@gmail.com \
--cc=dennis@kaarsemaker.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).